Merge pull request #1389 from kukulich/fix

Fixed ReflectionSourceStubber for enums

Author: Ocramius

src/SourceLocator/SourceStubber/ReflectionSourceStubber.php

@@ -4,6 +4,7 @@
 
 namespace Roave\BetterReflection\SourceLocator\SourceStubber;
 
+use BackedEnum;
 use LogicException;
 use PhpParser\Builder\Class_;
 use PhpParser\Builder\ClassConst;
@@ -39,6 +40,7 @@
 use ReflectionUnionType as CoreReflectionUnionType;
 use Roave\BetterReflection\Reflection\Annotation\AnnotationHelper;
 use Roave\BetterReflection\Util\ClassExistenceChecker;
+use UnitEnum;
 
 use function array_diff;
 use function array_key_exists;
@@ -285,6 +287,10 @@ private function addExtendsAndImplements(Class_|Interface_|Enum_ $classNode, Cor
         }
 
         foreach ($interfaces as $interfaceName) {
+            if ($classReflection->isEnum() && in_array($interfaceName, [BackedEnum::class, UnitEnum::class], true)) {
+                continue;
+            }
+
             $interfaceNode = new FullyQualified($interfaceName);
 
             if ($classNode instanceof Interface_) {
@@ -479,15 +485,27 @@ private function isMethodDeclaredInClass(CoreReflectionMethod $methodReflection,
             return false;
         }
 
+        $methodName = $methodReflection->getName();
+
         /** @var array<string, string> $traitAliases */
         $traitAliases = $classReflection->getTraitAliases();
 
-        if (array_key_exists($methodReflection->getName(), $traitAliases)) {
+        if (array_key_exists($methodName, $traitAliases)) {
             return false;
         }
 
         foreach ($classReflection->getTraits() as $trait) {
-            if ($trait->hasMethod($methodReflection->getName())) {
+            if ($trait->hasMethod($methodName)) {
+                return false;
+            }
+        }
+
+        if ($classReflection instanceof CoreReflectionEnum) {
+            if ($methodName === 'cases') {
+                return false;
+            }
+
+            if ($classReflection->isBacked() && in_array($methodName, ['from', 'tryFrom'], true)) {
                 return false;
             }
         }

test/unit/Fixture/EnumBackedForSourceStubberExpected.php

@@ -5,17 +5,8 @@
 /**
  * Class comment
  */
-enum EnumBackedForSourceStubber : int implements \BackedEnum
+enum EnumBackedForSourceStubber : int
 {
     case ONE = 1;
     case TWO = 2;
-    public static function cases() : array
-    {
-    }
-    public static function from(string|int $value) : static
-    {
-    }
-    public static function tryFrom(string|int $value) : ?static
-    {
-    }
 }

test/unit/Fixture/EnumPureForSourceStubberExpected.php

@@ -5,7 +5,7 @@
 /**
  * Class comment
  */
-enum EnumPureForSourceStubber implements \Roave\BetterReflectionTest\Fixture\ImplementedInterfaceForEnumSourceStubber, \UnitEnum
+enum EnumPureForSourceStubber implements \Roave\BetterReflectionTest\Fixture\ImplementedInterfaceForEnumSourceStubber
 {
     use \Roave\BetterReflectionTest\Fixture\UsedTraitForEnumSourceStubber;
     use \Roave\BetterReflectionTest\Fixture\UsedTraitToAliasForEnumSourceStubber {
@@ -22,7 +22,4 @@ enum EnumPureForSourceStubber implements \Roave\BetterReflectionTest\Fixture\Imp
     public function methodFromInterface()
     {
     }
-    public static function cases() : array
-    {
-    }
 }