Merge pull request #1523 from staabm/faster

Faster getTraits() methods

Author: Ocramius

src/Reflection/Adapter/ReflectionClass.php

@@ -384,14 +384,14 @@ public function getTraits(): array
     {
         $traits = $this->betterReflectionClass->getTraits();
 
-        /** @var list<trait-string> $traitNames */
-        $traitNames = array_map(static fn (BetterReflectionClass $trait): string => $trait->getName(), $traits);
+        $traitsByName = [];
+        foreach ($traits as $trait) {
+            /** @var trait-string $traitName */
+            $traitName                = $trait->getName();
+            $traitsByName[$traitName] = new self($trait);
+        }
 
-        /** @psalm-suppress ImpureFunctionCall */
-        return array_combine(
-            $traitNames,
-            array_map(static fn (BetterReflectionClass $trait): self => new self($trait), $traits),
-        );
+        return $traitsByName;
     }
 
     /**

src/Reflection/Adapter/ReflectionEnum.php

@@ -312,14 +312,14 @@ public function getTraits(): array
     {
         $traits = $this->betterReflectionEnum->getTraits();
 
-        /** @var list<trait-string> $traitNames */
-        $traitNames = array_map(static fn (BetterReflectionClass $trait): string => $trait->getName(), $traits);
+        $traitsByName = [];
+        foreach ($traits as $trait) {
+            /** @var trait-string $traitName */
+            $traitName                = $trait->getName();
+            $traitsByName[$traitName] = new ReflectionClass($trait);
+        }
 
-        /** @psalm-suppress ImpureFunctionCall */
-        return array_combine(
-            $traitNames,
-            array_map(static fn (BetterReflectionClass $trait): ReflectionClass => new ReflectionClass($trait), $traits),
-        );
+        return $traitsByName;
     }
 
     /** @return list<trait-string> */

src/Reflection/Adapter/ReflectionObject.php

@@ -316,14 +316,14 @@ public function getTraits(): array
     {
         $traits = $this->betterReflectionObject->getTraits();
 
-        /** @var list<trait-string> $traitNames */
-        $traitNames = array_map(static fn (BetterReflectionClass $trait): string => $trait->getName(), $traits);
+        $traitsByName = [];
+        foreach ($traits as $trait) {
+            /** @var trait-string $traitName */
+            $traitName                = $trait->getName();
+            $traitsByName[$traitName] = new ReflectionClass($trait);
+        }
 
-        /** @psalm-suppress ImpureFunctionCall */
-        return array_combine(
-            $traitNames,
-            array_map(static fn (BetterReflectionClass $trait): ReflectionClass => new ReflectionClass($trait), $traits),
-        );
+        return $traitsByName;
     }
 
     /**