Merge pull request #247 from crlimacastro/master

RobLoach · web-flow · commit 4fba82ccdaad · 2023-09-01T02:21:58.000-04:00
Fixed pitch yaw roll parameter names in Vector4::FromEuler
diff --git a/include/Vector4.hpp b/include/Vector4.hpp
@@ -130,8 +130,8 @@ class Vector4 : public ::Vector4 {
         return ::QuaternionFromAxisAngle(axis, angle);
     }
 
-    static inline Vector4 FromEuler(const float yaw, const float pitch, const float roll) {
-        return ::QuaternionFromEuler(yaw, pitch, roll);
+    static inline Vector4 FromEuler(const float pitch, const float yaw, const float roll) {
+        return ::QuaternionFromEuler(pitch, yaw, roll);
     }
 
     static inline Vector4 FromEuler(const ::Vector3& vector3) {

Original file line number	Diff line number	Diff line change
`@@ -130,8 +130,8 @@ class Vector4 : public ::Vector4 {`
`130`	`130`	`return ::QuaternionFromAxisAngle(axis, angle);`
`131`	`131`	`}`
`132`	`132`
`133`		`- static inline Vector4 FromEuler(const float yaw, const float pitch, const float roll) {`
`134`		`- return ::QuaternionFromEuler(yaw, pitch, roll);`
	`133`	`+ static inline Vector4 FromEuler(const float pitch, const float yaw, const float roll) {`
	`134`	`+ return ::QuaternionFromEuler(pitch, yaw, roll);`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`static inline Vector4 FromEuler(const ::Vector3& vector3) {`