Skip to content

Commit de010bc

Browse files
authored
Merge pull request #109 from RobLoach/vector
Clean up the Vector functions
2 parents c6c535c + 3d18140 commit de010bc

File tree

3 files changed

+59
-64
lines changed

3 files changed

+59
-64
lines changed

include/Vector2.hpp

Lines changed: 19 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -52,30 +52,25 @@ class Vector2 : public ::Vector2 {
5252
return *this;
5353
}
5454

55-
Vector2& operator=(const Vector2& vector2) {
56-
set(vector2);
57-
return *this;
58-
}
59-
60-
bool operator==(const Vector2& other) {
55+
bool operator==(const ::Vector2& other) {
6156
return x == other.x
6257
&& y == other.y;
6358
}
6459

6560
#ifndef RAYLIB_CPP_NO_MATH
66-
Vector2 Add(const Vector2& vector2) const {
61+
Vector2 Add(const ::Vector2& vector2) const {
6762
return Vector2Add(*this, vector2);
6863
}
6964

70-
Vector2 operator+(const Vector2& vector2) {
65+
Vector2 operator+(const ::Vector2& vector2) {
7166
return Vector2Add(*this, vector2);
7267
}
7368

74-
Vector2 Subtract(const Vector2& vector2) const {
69+
Vector2 Subtract(const ::Vector2& vector2) const {
7570
return Vector2Subtract(*this, vector2);
7671
}
7772

78-
Vector2 operator-(const Vector2& vector2) {
73+
Vector2 operator-(const ::Vector2& vector2) {
7974
return Vector2Subtract(*this, vector2);
8075
}
8176

@@ -87,11 +82,11 @@ class Vector2 : public ::Vector2 {
8782
return Vector2Negate(*this);
8883
}
8984

90-
Vector2 Multiply(const Vector2& vector2) const {
85+
Vector2 Multiply(const ::Vector2& vector2) const {
9186
return Vector2Multiply(*this, vector2);
9287
}
9388

94-
Vector2 operator*(const Vector2& vector2) {
89+
Vector2 operator*(const ::Vector2& vector2) {
9590
return Vector2Multiply(*this, vector2);
9691
}
9792

@@ -103,11 +98,11 @@ class Vector2 : public ::Vector2 {
10398
return Vector2Scale(*this, scale);
10499
}
105100

106-
Vector2 Divide(const Vector2& vector2) const {
101+
Vector2 Divide(const ::Vector2& vector2) const {
107102
return Vector2Divide(*this, vector2);
108103
}
109104

110-
Vector2 operator/(const Vector2& vector2) {
105+
Vector2 operator/(const ::Vector2& vector2) {
111106
return Vector2Divide(*this, vector2);
112107
}
113108

@@ -125,20 +120,20 @@ class Vector2 : public ::Vector2 {
125120
return *this;
126121
}
127122

128-
Vector2& operator+=(const Vector2& vector2) {
123+
Vector2& operator+=(const ::Vector2& vector2) {
129124
set(Vector2Add(*this, vector2));
130125

131126
return *this;
132127
}
133128

134-
Vector2& operator-=(const Vector2& vector2) {
129+
Vector2& operator-=(const ::Vector2& vector2) {
135130
set(Vector2Subtract(*this, vector2));
136131

137132
return *this;
138133
}
139134

140135

141-
Vector2& operator*=(const Vector2& vector2) {
136+
Vector2& operator*=(const ::Vector2& vector2) {
142137
set(Vector2Multiply(*this, vector2));
143138

144139
return *this;
@@ -150,7 +145,7 @@ class Vector2 : public ::Vector2 {
150145
return *this;
151146
}
152147

153-
Vector2& operator/=(const Vector2& vector2) {
148+
Vector2& operator/=(const ::Vector2& vector2) {
154149
set(Vector2Divide(*this, vector2));
155150

156151
return *this;
@@ -187,35 +182,35 @@ class Vector2 : public ::Vector2 {
187182
/**
188183
* Calculate two vectors dot product
189184
*/
190-
float DotProduct(const Vector2& vector2) const {
185+
float DotProduct(const ::Vector2& vector2) const {
191186
return Vector2DotProduct(*this, vector2);
192187
}
193188

194189
/**
195190
* Calculate angle from two vectors in X-axis
196191
*/
197-
float Angle(const Vector2& vector2) const {
192+
float Angle(const ::Vector2& vector2) const {
198193
return Vector2Angle(*this, vector2);
199194
}
200195

201196
/**
202197
* Calculate distance between two vectors
203198
*/
204-
float Distance(const Vector2& vector2) const {
199+
float Distance(const ::Vector2& vector2) const {
205200
return Vector2Distance(*this, vector2);
206201
}
207202

208203
/**
209204
* Calculate linear interpolation between two vectors
210205
*/
211-
Vector2 Lerp(const Vector2& vector2, const float amount) const {
206+
Vector2 Lerp(const ::Vector2& vector2, const float amount) const {
212207
return Vector2Lerp(*this, vector2, amount);
213208
}
214209

215210
/**
216211
* Calculate reflected vector to normal
217212
*/
218-
Vector2 Reflect(const Vector2& normal) const {
213+
Vector2 Reflect(const ::Vector2& normal) const {
219214
return Vector2Reflect(*this, normal);
220215
}
221216

@@ -229,7 +224,7 @@ class Vector2 : public ::Vector2 {
229224
/**
230225
* Move Vector towards target
231226
*/
232-
Vector2 MoveTowards(Vector2 target, float maxDistance) const {
227+
Vector2 MoveTowards(const ::Vector2& target, float maxDistance) const {
233228
return Vector2MoveTowards(*this, target, maxDistance);
234229
}
235230

include/Vector3.hpp

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -65,19 +65,19 @@ class Vector3 : public ::Vector3 {
6565
}
6666

6767
#ifndef RAYLIB_CPP_NO_MATH
68-
Vector3 Add(const Vector3& vector3) {
68+
Vector3 Add(const ::Vector3& vector3) {
6969
return Vector3Add(*this, vector3);
7070
}
7171

72-
Vector3 operator+(const Vector3& vector3) {
72+
Vector3 operator+(const ::Vector3& vector3) {
7373
return Vector3Add(*this, vector3);
7474
}
7575

76-
Vector3 Subtract(const Vector3& vector3) {
76+
Vector3 Subtract(const ::Vector3& vector3) {
7777
return Vector3Subtract(*this, vector3);
7878
}
7979

80-
Vector3 operator-(const Vector3& vector3) {
80+
Vector3 operator-(const ::Vector3& vector3) {
8181
return Vector3Subtract(*this, vector3);
8282
}
8383

@@ -89,11 +89,11 @@ class Vector3 : public ::Vector3 {
8989
return Vector3Negate(*this);
9090
}
9191

92-
Vector3 Multiply(const Vector3& vector3) {
92+
Vector3 Multiply(const ::Vector3& vector3) {
9393
return Vector3Multiply(*this, vector3);
9494
}
9595

96-
Vector3 operator*(const Vector3& vector3) {
96+
Vector3 operator*(const ::Vector3& vector3) {
9797
return Vector3Multiply(*this, vector3);
9898
}
9999

@@ -105,11 +105,11 @@ class Vector3 : public ::Vector3 {
105105
return Vector3Scale(*this, scale);
106106
}
107107

108-
Vector3 Divide(const Vector3& vector3) {
108+
Vector3 Divide(const ::Vector3& vector3) {
109109
return Vector3Divide(*this, vector3);
110110
}
111111

112-
Vector3 operator/(const Vector3& vector3) {
112+
Vector3 operator/(const ::Vector3& vector3) {
113113
return Vector3Divide(*this, vector3);
114114
}
115115

@@ -125,20 +125,20 @@ class Vector3 : public ::Vector3 {
125125
return Divide(div);
126126
}
127127

128-
Vector3& operator+=(const Vector3& vector3) {
128+
Vector3& operator+=(const ::Vector3& vector3) {
129129
set(Vector3Add(*this, vector3));
130130

131131
return *this;
132132
}
133133

134-
Vector3& operator-=(const Vector3& vector3) {
134+
Vector3& operator-=(const ::Vector3& vector3) {
135135
set(Vector3Subtract(*this, vector3));
136136

137137
return *this;
138138
}
139139

140140

141-
Vector3& operator*=(const Vector3& vector3) {
141+
Vector3& operator*=(const ::Vector3& vector3) {
142142
set(Vector3Multiply(*this, vector3));
143143

144144
return *this;
@@ -150,7 +150,7 @@ class Vector3 : public ::Vector3 {
150150
return *this;
151151
}
152152

153-
Vector3& operator/=(const Vector3& vector3) {
153+
Vector3& operator/=(const ::Vector3& vector3) {
154154
x /= vector3.x;
155155
y /= vector3.y;
156156
z /= vector3.z;
@@ -174,51 +174,51 @@ class Vector3 : public ::Vector3 {
174174
return Vector3Normalize(*this);
175175
}
176176

177-
float DotProduct(const Vector3& vector3) {
177+
float DotProduct(const ::Vector3& vector3) {
178178
return Vector3DotProduct(*this, vector3);
179179
}
180180

181-
float Distance(const Vector3& vector3) {
181+
float Distance(const ::Vector3& vector3) {
182182
return Vector3Distance(*this, vector3);
183183
}
184184

185-
Vector3 Lerp(const Vector3& vector3, const float amount) {
185+
Vector3 Lerp(const ::Vector3& vector3, const float amount) {
186186
return Vector3Lerp(*this, vector3, amount);
187187
}
188188

189-
Vector3 CrossProduct(const Vector3& vector3) {
189+
Vector3 CrossProduct(const ::Vector3& vector3) {
190190
return Vector3CrossProduct(*this, vector3);
191191
}
192192

193193
Vector3 Perpendicular() {
194194
return Vector3Perpendicular(*this);
195195
}
196196

197-
void OrthoNormalize(Vector3* vector3) {
197+
void OrthoNormalize(::Vector3* vector3) {
198198
Vector3OrthoNormalize(this, vector3);
199199
}
200200

201201
Vector3 Transform(const ::Matrix& matrix) {
202202
return Vector3Transform(*this, matrix);
203203
}
204204

205-
Vector3 RotateByQuaternion(Quaternion quaternion) {
205+
Vector3 RotateByQuaternion(const ::Quaternion& quaternion) {
206206
return Vector3RotateByQuaternion(*this, quaternion);
207207
}
208208

209-
Vector3 Reflect(const Vector3& normal) {
209+
Vector3 Reflect(const ::Vector3& normal) {
210210
return Vector3Reflect(*this, normal);
211211
}
212212

213-
Vector3 Min(const Vector3& vector3) {
213+
Vector3 Min(const ::Vector3& vector3) {
214214
return Vector3Min(*this, vector3);
215215
}
216216

217-
Vector3 Max(const Vector3& vector3) {
217+
Vector3 Max(const ::Vector3& vector3) {
218218
return Vector3Max(*this, vector3);
219219
}
220220

221-
Vector3 Barycenter(const Vector3& a, const Vector3& b, const Vector3& c) {
221+
Vector3 Barycenter(const ::Vector3& a, const ::Vector3& b, const ::Vector3& c) {
222222
return Vector3Barycenter(*this, a, b, c);
223223
}
224224

@@ -231,7 +231,7 @@ class Vector3 : public ::Vector3 {
231231
}
232232
#endif
233233

234-
inline Vector3& DrawLine3D(::Vector3 endPos, ::Color color) {
234+
inline Vector3& DrawLine3D(const ::Vector3& endPos, ::Color color) {
235235
::DrawLine3D(*this, endPos, color);
236236
return *this;
237237
}
@@ -243,7 +243,7 @@ class Vector3 : public ::Vector3 {
243243

244244
inline Vector3& DrawCircle3D(
245245
float radius,
246-
Vector3 rotationAxis,
246+
const ::Vector3& rotationAxis,
247247
float rotationAngle,
248248
Color color) {
249249
::DrawCircle3D(*this, radius, rotationAxis, rotationAngle, color);
@@ -255,7 +255,7 @@ class Vector3 : public ::Vector3 {
255255
return *this;
256256
}
257257

258-
inline Vector3& DrawCube(::Vector3 size, ::Color color) {
258+
inline Vector3& DrawCube(const ::Vector3& size, ::Color color) {
259259
::DrawCubeV(*this, size, color);
260260
return *this;
261261
}
@@ -265,7 +265,7 @@ class Vector3 : public ::Vector3 {
265265
return *this;
266266
}
267267

268-
inline Vector3& DrawCubeWires(::Vector3 size, ::Color color) {
268+
inline Vector3& DrawCubeWires(const ::Vector3& size, ::Color color) {
269269
::DrawCubeWiresV(*this, size, color);
270270
return *this;
271271
}
@@ -280,17 +280,17 @@ class Vector3 : public ::Vector3 {
280280
return *this;
281281
}
282282

283-
inline Vector3& DrawSphere(float radius, Color color) {
283+
inline Vector3& DrawSphere(float radius, ::Color color) {
284284
::DrawSphere(*this, radius, color);
285285
return *this;
286286
}
287287

288-
inline Vector3& DrawSphere(float radius, int rings, int slices, Color color) {
288+
inline Vector3& DrawSphere(float radius, int rings, int slices, ::Color color) {
289289
::DrawSphereEx(*this, radius, rings, slices, color);
290290
return *this;
291291
}
292292

293-
inline Vector3& DrawSphereWires(float radius, int rings, int slices, Color color) {
293+
inline Vector3& DrawSphereWires(float radius, int rings, int slices, ::Color color) {
294294
::DrawSphereWires(*this, radius, rings, slices, color);
295295
return *this;
296296
}
@@ -307,7 +307,7 @@ class Vector3 : public ::Vector3 {
307307
return *this;
308308
}
309309

310-
inline Vector3& DrawPlane(::Vector2 size, ::Color color) {
310+
inline Vector3& DrawPlane(const ::Vector2& size, ::Color color) {
311311
::DrawPlane(*this, size, color);
312312
return *this;
313313
}
@@ -320,7 +320,7 @@ class Vector3 : public ::Vector3 {
320320
/**
321321
* Detect collision between two spheres
322322
*/
323-
inline bool CheckCollision(float radius1, Vector3 center2, float radius2) {
323+
inline bool CheckCollision(float radius1, const ::Vector3& center2, float radius2) {
324324
return CheckCollisionSpheres(*this, radius1, center2, radius2);
325325
}
326326

0 commit comments

Comments
 (0)