Standalone generation script #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, the plugin is running the python script only once, so I'm not sure how a big problem the loading time is. Is it that bad? Should we create ticket for a better performance? Anyway, I don't like having two nearly identical scripts in the repo. Can the new script be used from the plugin? If yes, then lets drop the old one altogether... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a standalone script so sourcing the plugin to zsh is not required, which saves loading time on shell startup.
Generating completions with the zsh-completion-generator is rather something you do once in a while and does not need to be sourced every time you start zsh in my opinion.
Also made the script a bit more verbose (help message, errors) and added support for custom help commands.
EDIT:
In addition one could add the following to the usage message to be super clear how to get the output into working zsh completions.