DYN-7899: Type forward nodecategoryattribute for use in external node libs such as protogeometry (DynamoDS#16914)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: aparajit-pratap

doc/distrib/xml/en-US/FFITarget.xml

@@ -19,29 +19,7 @@ public NodeNameAttribute(string elementName)
     }
 
     /// <summary>
-    ///     The NodeCategoryAttribute attribute allows the node implementer
-    ///     to define in which category node will appear. 
-    /// </summary>
-    [AttributeUsage(AttributeTargets.All)]
-    public class NodeCategoryAttribute : Attribute
-    {
-        /// <summary>
-        /// Creates NodeCategoryAttribute.
-        /// </summary>
-        /// <param name="category">Full name of the category. E.g. Core.List.Create</param>
-        public NodeCategoryAttribute(string category)
-        {
-            ElementCategory = category;
-        }
-
-        /// <summary>
-        /// Full name of the category. E.g. Core.List.Create
-        /// </summary>
-        public string ElementCategory { get; set; }
-    }
-
-    /// <summary>
-    ///     The NodeCategoryAttribute attribute allows the node implementer
+    ///     The NodeSearchTagsAttribute attribute allows the node implementer
     ///     to define search tags.
     /// </summary>
     [AttributeUsage(AttributeTargets.All)]

src/DynamoCore/Graph/Nodes/Attributes.cs

@@ -64,6 +64,8 @@
 [assembly: InternalsVisibleTo("MCPServer")]
 
 // Disable PublicAPIAnalyzer errors for this type as they're already added to the public API text file
-#pragma warning disable RS0016 
+#pragma warning disable RS0016
 [assembly: TypeForwardedTo(typeof(Dynamo.Scheduler.Disposable))]
+// NodeCategoryAttribute moved to DynamoServices so libraries that reference only DynamoServices (e.g. LibG) can use it.
+[assembly: TypeForwardedTo(typeof(Dynamo.Graph.Nodes.NodeCategoryAttribute))]
 #pragma warning restore RS0016

src/DynamoCore/Properties/AssemblyInfo.cs

@@ -928,10 +928,6 @@ Dynamo.Graph.Nodes.LacingStrategy.Disabled = 0 -> Dynamo.Graph.Nodes.LacingStrat
 Dynamo.Graph.Nodes.LacingStrategy.First = 1 -> Dynamo.Graph.Nodes.LacingStrategy
 Dynamo.Graph.Nodes.LacingStrategy.Longest = 3 -> Dynamo.Graph.Nodes.LacingStrategy
 Dynamo.Graph.Nodes.LacingStrategy.Shortest = 2 -> Dynamo.Graph.Nodes.LacingStrategy
-Dynamo.Graph.Nodes.NodeCategoryAttribute
-Dynamo.Graph.Nodes.NodeCategoryAttribute.ElementCategory.get -> string
-Dynamo.Graph.Nodes.NodeCategoryAttribute.ElementCategory.set -> void
-Dynamo.Graph.Nodes.NodeCategoryAttribute.NodeCategoryAttribute(string category) -> void
 Dynamo.Graph.Nodes.NodeDeprecatedAttribute
 Dynamo.Graph.Nodes.NodeDeprecatedAttribute.NodeDeprecatedAttribute() -> void
 Dynamo.Graph.Nodes.NodeDescriptionAttribute

src/DynamoCore/PublicAPI.Unshipped.txt

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
     <ImportGroup Label="PropertySheets">
         <Import Project="$(SolutionDir)Config\CS_SDK.props" />
     </ImportGroup>
@@ -19,9 +19,13 @@
         <TargetFrameworks>netstandard2.0;net8.0;net10.0</TargetFrameworks>
     </PropertyGroup>
     <PropertyGroup>
-        <NoWarn>MSB3539;CS1591;NUnit2005;NUnit2007;CS0618;CS0612;CS0672</NoWarn>
+        <NoWarn>MSB3539;CS1591;NUnit2005;NUnit2007;CS0618;CS0612;CS0672;RS0026</NoWarn>
     </PropertyGroup>
     <ItemGroup>
+        <PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4">
+            <PrivateAssets>all</PrivateAssets>
+            <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
         <!--exclude these dependencies as Sys.Ref.MetadataLoadContext.dll is already pulled in from other projects and the transitive deps are part of the .net8/net10 runtime.-->
         <PackageReference Include="System.Reflection.MetadataLoadContext" Version="8.0.0" ExcludeAssets="runtime" />
     </ItemGroup>

src/NodeServices/DynamoServices.csproj

@@ -0,0 +1,28 @@
+using System;
+
+namespace Dynamo.Graph.Nodes
+{
+    /// <summary>
+    ///     The NodeCategoryAttribute attribute allows the node implementer
+    ///     to define in which category node will appear.
+    ///     Moved from DynamoCore to DynamoServices so libraries that reference only DynamoServices
+    ///     (e.g. LibG) can use it to control Create/Actions/Query grouping for Zero Touch nodes.
+    /// </summary>
+    [AttributeUsage(AttributeTargets.All)]
+    public class NodeCategoryAttribute : Attribute
+    {
+        /// <summary>
+        /// Creates NodeCategoryAttribute.
+        /// </summary>
+        /// <param name="category">Full name of the category. E.g. Core.List.Create, or "Create", "Actions", "Query" for grouping.</param>
+        public NodeCategoryAttribute(string category)
+        {
+            ElementCategory = category;
+        }
+
+        /// <summary>
+        /// Full name of the category. E.g. Core.List.Create
+        /// </summary>
+        public string ElementCategory { get; set; }
+    }
+}