Optimize Redis

Author: RobiNN1

src/Dashboards/Redis/Compatibility/Predis.php

@@ -131,46 +131,40 @@ public function rawcommand(string $command, mixed ...$arguments): mixed {
      * @return array<string, mixed>
      */
     public function pipelineKeys(array $keys): array {
-        $results = $this->pipeline(function ($pipe) use ($keys): void {
+        $lua_memory = 'return redis.call("MEMORY", "USAGE", KEYS[1])';
+        $lua_type = /* @lang Lua */
+            <<<LUA
+            local type = redis.call("TYPE", KEYS[1])["ok"]
+            if type == "set" then return redis.call("SCARD", KEYS[1])
+            elseif type == "list" then return redis.call("LLEN", KEYS[1])
+            elseif type == "zset" then return redis.call("ZCARD", KEYS[1])
+            elseif type == "hash" then return redis.call("HLEN", KEYS[1])
+            elseif type == "stream" then return redis.call("XLEN", KEYS[1])
+            else return nil end
+        LUA;
+
+        $results = $this->pipeline(function ($pipe) use ($keys, $lua_memory, $lua_type): void {
             foreach ($keys as $key) {
                 $pipe->ttl($key);
                 $pipe->type($key);
-                $pipe->eval('return redis.call("MEMORY", "USAGE", KEYS[1])', 1, $key);
+                $pipe->eval($lua_memory, 1, $key);
+                $pipe->eval($lua_type, 1, $key);
             }
         });
 
         $data = [];
 
         foreach ($keys as $i => $key) {
-            $index = $i * 3;
+            $index = $i * 4;
+
             $data[$key] = [
                 'ttl'   => $results[$index],
                 'type'  => (string) $results[$index + 1],
-                'size'  => is_int($results[$index + 2]) ? $results[$index + 2] : 0,
-                'count' => null,
+                'size'  => $results[$index + 2] ?? 0,
+                'count' => is_int($results[$index + 3]) ? $results[$index + 3] : null,
             ];
         }
 
-        $count_results = $this->pipeline(function ($pipe) use ($keys, $data): void {
-            foreach ($keys as $key) {
-                $lua = match ($data[$key]['type']) {
-                    'set' => 'return redis.call("SCARD", KEYS[1])',
-                    'list' => 'return redis.call("LLEN", KEYS[1])',
-                    'zset' => 'return redis.call("ZCARD", KEYS[1])',
-                    'hash' => 'return redis.call("HLEN", KEYS[1])',
-                    'stream' => 'return redis.call("XLEN", KEYS[1])',
-                    default => 'return nil',
-                };
-
-                $pipe->eval($lua, 1, $key);
-            }
-        });
-
-        foreach ($keys as $i => $key) {
-            $count = $count_results[$i] ?? null;
-            $data[$key]['count'] = $data[$key]['type'] !== 'none' && is_int($count) ? $count : null;
-        }
-
         return $data;
     }
 

src/Dashboards/Redis/Compatibility/Redis.php

@@ -149,25 +149,25 @@ public function streamAdd(string $key, string $id, array $messages): string {
      * @throws RedisException
      */
     public function pipelineKeys(array $keys): array {
-        $pipeline = $this->multi(self::PIPELINE);
+        $pipe = $this->multi(self::PIPELINE);
 
         foreach ($keys as $key) {
-            $pipeline->ttl($key);
-            $pipeline->type($key);
-            $pipeline->rawcommand('MEMORY', 'USAGE', $key);
-            $pipeline->rawcommand('SCARD', $key);
-            $pipeline->rawcommand('LLEN', $key);
-            $pipeline->rawcommand('ZCARD', $key);
-            $pipeline->rawcommand('HLEN', $key);
-            $pipeline->rawcommand('XLEN', $key);
+            $pipe->ttl($key);
+            $pipe->type($key);
+            $pipe->rawcommand('MEMORY', 'USAGE', $key);
+            $pipe->rawcommand('SCARD', $key);
+            $pipe->rawcommand('LLEN', $key);
+            $pipe->rawcommand('ZCARD', $key);
+            $pipe->rawcommand('HLEN', $key);
+            $pipe->rawcommand('XLEN', $key);
         }
 
-        $results = $pipeline->exec();
+        $results = $pipe->exec();
 
         $data = [];
 
         foreach ($keys as $i => $key) {
-            $index = $i * 8;
+            $index = $i * 8; // index + count of pipeline commands
             $type = $this->getType($results[$index + 1]);
 
             $count = match ($type) {