Fixes

Author: RobiNN1

src/Dashboards/APCu/APCuTrait.php

@@ -256,7 +256,7 @@ private function keysTreeView(array $keys): array {
             $path = '';
 
             foreach ($parts as $i => $part) {
-                $path = $path ? $path.$separator.$part : $part;
+                $path = $path !== '' && $path !== '0' ? $path.$separator.$part : $part;
 
                 if ($i === count($parts) - 1) { // check last part
                     $current[] = [

src/Dashboards/Memcached/MemcachedTrait.php

@@ -278,7 +278,7 @@ private function keysTreeView(array $keys): array {
             $path = '';
 
             foreach ($parts as $i => $part) {
-                $path = $path ? $path.$separator.$part : $part;
+                $path = $path !== '' && $path !== '0' ? $path.$separator.$part : $part;
 
                 if ($i === count($parts) - 1) { // check last part
                     $current[] = [

src/Dashboards/Redis/Compatibility/Predis.php

@@ -143,7 +143,7 @@ public function pipelineKeys(array $keys): array {
             return [];
         }
 
-        $results = $this->pipeline(function ($pipe) use ($keys, $script_sha) {
+        $results = $this->pipeline(function ($pipe) use ($keys, $script_sha): void {
             foreach ($keys as $key) {
                 $pipe->evalsha($script_sha, 1, $key);
             }

src/Dashboards/Redis/RedisTrait.php

@@ -423,7 +423,7 @@ private function keysTreeView(array $keys): array {
             $path = '';
 
             foreach ($parts as $i => $part) {
-                $path = $path ? $path.$separator.$part : $part;
+                $path = $path !== '' && $path !== '0' ? $path.$separator.$part : $part;
 
                 if ($i === count($parts) - 1) { // check last part
                     $current[] = [

src/Dashboards/Redis/RedisTypes.php

@@ -154,6 +154,7 @@ public function store(string $type, string $key, string $value, string $old_valu
                     $this->redis->sRem($key, $old_value);
                     $this->redis->sAdd($key, $value);
                 }
+
                 break;
             case 'list':
                 $size = $this->redis->lLen($key);
@@ -169,6 +170,7 @@ public function store(string $type, string $key, string $value, string $old_valu
                     Http::stopRedirect();
                     Helpers::alert($this->template, 'Out of bounds index.', 'error');
                 }
+
                 break;
             case 'zset':
                 $this->redis->zRem($key, $old_value);

tests/Dashboards/Redis/RedisTestCase.php

@@ -365,9 +365,11 @@ public function testPipelineKeys(): void {
         foreach (['a', 'b', 'c'] as $value) {
             $this->dashboard->store('list', 'pu-test-list', $value);
         }
+
         foreach (['m1', 'm2', 'm3', 'm4'] as $member) {
             $this->dashboard->store('set', 'pu-test-set', $member);
         }
+
         foreach (['field1' => 'val1', 'field2' => 'val2'] as $field => $value) {
             $this->dashboard->store('hash', 'pu-test-hash', $value, '', ['hash_key' => $field]);
         }

tests/HelpersTest.php

@@ -191,38 +191,39 @@ public function testCountChildren(): void {
         $expected = [
             [
                 'type'     => 'folder',
-                'count'    => 4,
                 'children' => [
                     ['type' => 'file'],
                     ['type' => 'file'],
                     [
-                        'type'     => 'folder',
-                        'count'    => 2,
+                        'type' => 'folder',
+
                         'children' => [
                             ['type' => 'file'],
                             ['type' => 'file'],
                         ],
+                        'count'    => 2,
                     ],
                 ],
+                'count'    => 4,
             ],
             ['type' => 'file'],
             ['type' => 'file'],
         ];
 
         $count = Helpers::countChildren($tree);
-        $this->assertEquals(6, $count);
-        $this->assertEquals($expected, $tree);
+        $this->assertSame(6, $count);
+        $this->assertSame($expected, $tree);
     }
 
     public function testCountChildrenEmpty(): void {
         $tree = [];
         $count = Helpers::countChildren($tree);
-        $this->assertEquals(0, $count);
+        $this->assertSame(0, $count);
     }
 
     public function testCountChildrenNoFolders(): void {
         $tree = [['type' => 'file'], ['type' => 'file'], ['type' => 'file'],];
         $count = Helpers::countChildren($tree);
-        $this->assertEquals(3, $count);
+        $this->assertSame(3, $count);
     }
 }