Remove unnecessary compatibility layer for Memcached

Author: RobiNN1

src/Dashboards/Memcached/Compatibility/Memcache.php

@@ -25,7 +25,7 @@ class MemcachedDashboard implements DashboardInterface {
 
     private int $current_server;
 
-    public Compatibility\Memcached|Compatibility\Memcache|Compatibility\PHPMem $memcached;
+    public PHPMem $memcached;
 
     /**
      * @var array<int, mixed>
@@ -42,7 +42,7 @@ public function __construct(private readonly Template $template) {
     public static function check(): bool {
         return extension_loaded('memcached') ||
             extension_loaded('memcache') ||
-            class_exists(Compatibility\PHPMem::class);
+            class_exists(PHPMem::class);
     }
 
     /**
@@ -75,17 +75,13 @@ public function dashboardInfo(): array {
      *
      * @throws DashboardException
      */
-    public function connect(array $server): Compatibility\Memcached|Compatibility\Memcache|Compatibility\PHPMem {
+    public function connect(array $server): PHPMem {
         $server['port'] ??= 11211;
 
-        if (extension_loaded('memcached')) {
-            $memcached = new Compatibility\Memcached($server);
-        } elseif (extension_loaded('memcache')) {
-            $memcached = new Compatibility\Memcache($server);
-        } elseif (class_exists(Compatibility\PHPMem::class)) {
-            $memcached = new Compatibility\PHPMem($server);
+        if (class_exists(PHPMem::class)) {
+            $memcached = new PHPMem($server);
         } else {
-            throw new DashboardException('Memcache(d) extension or PHPMem client is not installed.');
+            throw new DashboardException('PHPMem client is not installed.');
         }
 
         if (!$memcached->isConnected()) {

src/Dashboards/Memcached/Compatibility/Memcached.php

@@ -17,11 +17,8 @@
 
 trait MemcachedTrait {
     private function panels(): string {
-        if (extension_loaded('memcached') || extension_loaded('memcache')) {
-            $memcached = extension_loaded('memcached') ? 'd' : '';
-            $title = 'PHP Memcache'.$memcached.' extension v'.phpversion('memcache'.$memcached);
-        } elseif (class_exists(Compatibility\PHPMem::class)) {
-            $title = 'PHPMem v'.Compatibility\PHPMem::VERSION;
+        if (class_exists(PHPMem::class)) {
+            $title = 'PHPMem v'.PHPMem::VERSION;
         }
 
         try {
@@ -162,7 +159,7 @@ public function saveKey(): void {
             $this->memcached->delete($old_key);
         }
 
-        $this->memcached->store($key, $value, $expire);
+        $this->memcached->set($key, $value, $expire);
 
         Http::redirect([], ['view' => 'key', 'ttl' => $expire, 'key' => $key]);
     }
@@ -241,7 +238,7 @@ private function mainDashboard(): string {
         if (isset($_POST['submit_import_key'])) {
             Helpers::import(
                 fn (string $key): bool => $this->memcached->exists($key),
-                fn (string $key, string $value, int $ttl): bool => $this->memcached->store($key, base64_decode($value), $ttl)
+                fn (string $key, string $value, int $ttl): bool => $this->memcached->set($key, base64_decode($value), $ttl)
             );
         }