PHPStan v2

Author: RobiNN1

composer.json

@@ -29,7 +29,7 @@
   },
   "require-dev": {
     "clue/phar-composer": "^1.4",
-    "phpstan/phpstan": "^1.12",
+    "phpstan/phpstan": "^2.0",
     "phpunit/phpunit": "^11.4"
   },
   "suggest": {

phpstan.neon

@@ -1,4 +1,5 @@
 parameters:
   level: 6
+  treatPhpDocTypesAsCertain: false
   paths:
     - src

src/Config.php

@@ -52,11 +52,9 @@ public static function get(string $key, $default = null) {
      * @return array<string, mixed>
      */
     private static function getEnvConfig(array $config): array {
-        $vars = preg_grep('/^PCA_/', array_keys(getenv()));
-
-        if ($vars !== false && count($vars)) {
-            foreach ($vars as $var) {
-                self::envVarToArray($config, $var, (string) getenv($var));
+        foreach (getenv() as $var => $value) {
+            if (str_starts_with($var, 'PCA_')) {
+                $config = self::envVarToArray($config, $var, $value);
             }
         }
 
@@ -66,14 +64,15 @@ private static function getEnvConfig(array $config): array {
     /**
      * Convert ENV variable to an array.
      *
-     * It allows app to use ENV variables and config.php together.
+     * It allows the app to use ENV variables and config.php together.
      *
      * @param array<string, mixed> $array
+     *
+     * @return array<string, mixed>
      */
-    private static function envVarToArray(array &$array, string $var, string $value): void {
-        $var = str_replace('PCA_', '', $var);
-        $keys = explode('_', $var);
-        $keys = array_map(strtolower(...), $keys);
+    private static function envVarToArray(array $array, string $var, string $value): array {
+        $var = substr($var, 4);
+        $keys = array_map(strtolower(...), explode('_', $var));
 
         foreach ($keys as $i => $key) {
             if (count($keys) === 1) {
@@ -85,8 +84,6 @@ private static function envVarToArray(array &$array, string $var, string $value)
             if (!isset($array[$key]) || !is_array($array[$key])) {
                 $array[$key] = [];
             }
-
-            $array = &$array[$key];
         }
 
         if (json_validate($value)) {
@@ -98,6 +95,8 @@ private static function envVarToArray(array &$array, string $var, string $value)
         }
 
         $array[array_shift($keys)] = $value;
+
+        return $array;
     }
 
     /**

src/Dashboards/APCu/APCuDashboard.php

@@ -23,7 +23,7 @@ public static function check(): bool {
     }
 
     /**
-     * @return array<string, string|array<int, string>>
+     * @return array<string, array<int, string>|string>
      */
     public function dashboardInfo(): array {
         return [

src/Dashboards/APCu/APCuTrait.php

@@ -120,10 +120,10 @@ private function viewKey(): string {
     public function saveKey(): void {
         $key = Http::post('key', '');
         $expire = Http::post('expire', 0);
-        $old_key = Http::post('old_key', '');
+        $old_key = (string) Http::post('old_key', '');
         $value = Value::converter(Http::post('value', ''), Http::post('encoder', ''), 'save');
 
-        if ($old_key !== '' && $old_key !== $key) {
+        if ($old_key !== $key) {
             apcu_delete($old_key);
         }
 

src/Dashboards/DashboardInterface.php

@@ -17,7 +17,7 @@ public static function check(): bool;
     /**
      * Array that contains key, name, and optionally an icon or colors.
      *
-     * @return array<string, string|array<int, string>>
+     * @return array<string, array<int, string>|string>
      */
     public function dashboardInfo(): array;
 

src/Dashboards/Memcached/MemcachedTrait.php

@@ -153,10 +153,10 @@ private function viewKey(): string {
     public function saveKey(): void {
         $key = Http::post('key', '');
         $expire = Http::post('expire', 0);
-        $old_key = Http::post('old_key', '');
+        $old_key = (string) Http::post('old_key', '');
         $value = Value::converter(Http::post('value', ''), Http::post('encoder', ''), 'save');
 
-        if ($old_key !== '' && $old_key !== $key) {
+        if ($old_key !== $key) {
             $this->memcached->delete($old_key);
         }
 

src/Dashboards/OPCache/OPCacheDashboard.php

@@ -19,11 +19,11 @@ public function __construct(private readonly Template $template) {
     }
 
     public static function check(): bool {
-        return extension_loaded('Zend OPcache') && ini_get('opcache.restrict_api') !== null;
+        return extension_loaded('Zend OPcache') && ini_get('opcache.restrict_api') !== false;
     }
 
     /**
-     * @return array<string, string|array<int, string>>
+     * @return array<string, array<int, string>|string>
      */
     public function dashboardInfo(): array {
         return [

src/Dashboards/Realpath/RealpathDashboard.php

@@ -30,7 +30,7 @@ public static function check(): bool {
     }
 
     /**
-     * @return array<string, string>
+     * @return array<string, array<int, string>|string>
      */
     public function dashboardInfo(): array {
         return [

src/Dashboards/Redis/RedisDashboard.php

@@ -42,7 +42,7 @@ public static function check(): bool {
     }
 
     /**
-     * @return array<string, string|array<int, string>>
+     * @return array<string, array<int, string>|string>
      */
     public function dashboardInfo(): array {
         return [