Fixes

Author: RobiNN1

src/Dashboards/Memcached/MemcachedTrait.php

@@ -485,7 +485,6 @@ private function formatField(array $fields, array $item): array {
 
         foreach ($fields as $key => [$label, $type]) {
             $value = $item[$key] ?? 0;
-            jdump([$label, $value, $type]);
             $formatted[$label] = Format::{$type}($value);
         }
 

src/Dashboards/Redis/Compatibility/RedisModules.php

@@ -26,7 +26,7 @@ public function getModules(): array {
             return [];
         }
 
-        if (!is_array($list) || count($list) === 0) {
+        if (!is_array($list) || $list === []) {
             return [];
         }
 

src/Format.php

@@ -84,7 +84,7 @@ public static function seconds(int $time): string {
             }
         }
 
-        return $time_parts ? implode(' ', $time_parts) : '0 seconds';
+        return $time_parts !== [] ? implode(' ', $time_parts) : '0 seconds';
     }
 
     public static function time(int $time): string {

templates/dashboards/memcached.twig

@@ -63,6 +63,8 @@
                     panel_title: 'Item ' ~ item,
                     array: data,
                 }) }}
+            {% else %}
+                No items.
             {% endfor %}
         </div>
     </div>

tests/HelpersTest.php

@@ -137,34 +137,34 @@ public function testSortKeys(string $sortdir, string $sortcol, array $keys, arra
 
     public static function sortKeysProvider(): Iterator {
         yield 'no sorting' => [
-            'sortdir'  => 'none',
-            'sortcol'  => 'column1',
-            'keys'     => [['info' => ['column1' => 'value1']], ['info' => ['column1' => 'value2']], ['info' => ['column1' => 'value3']],],
-            'expected' => [['info' => ['column1' => 'value1']], ['info' => ['column1' => 'value2']], ['info' => ['column1' => 'value3']],],
+            'none',
+            'column1',
+            [['info' => ['column1' => 'value1']], ['info' => ['column1' => 'value2']], ['info' => ['column1' => 'value3']],],
+            [['info' => ['column1' => 'value1']], ['info' => ['column1' => 'value2']], ['info' => ['column1' => 'value3']],],
         ];
         yield 'ascending sort' => [
-            'sortdir'  => 'asc',
-            'sortcol'  => 'column1',
-            'keys'     => [['info' => ['column1' => 'value3']], ['info' => ['column1' => 'value1']], ['info' => ['column1' => 'value2']],],
-            'expected' => [['info' => ['column1' => 'value1']], ['info' => ['column1' => 'value2']], ['info' => ['column1' => 'value3']],],
+            'asc',
+            'column1',
+            [['info' => ['column1' => 'value3']], ['info' => ['column1' => 'value1']], ['info' => ['column1' => 'value2']],],
+            [['info' => ['column1' => 'value1']], ['info' => ['column1' => 'value2']], ['info' => ['column1' => 'value3']],],
         ];
         yield 'descending sort' => [
-            'sortdir'  => 'desc',
-            'sortcol'  => 'column1',
-            'keys'     => [['info' => ['column1' => 'value1']], ['info' => ['column1' => 'value2']], ['info' => ['column1' => 'value3']],],
-            'expected' => [['info' => ['column1' => 'value3']], ['info' => ['column1' => 'value2']], ['info' => ['column1' => 'value1']],],
+            'desc',
+            'column1',
+            [['info' => ['column1' => 'value1']], ['info' => ['column1' => 'value2']], ['info' => ['column1' => 'value3']],],
+            [['info' => ['column1' => 'value3']], ['info' => ['column1' => 'value2']], ['info' => ['column1' => 'value1']],],
         ];
         yield 'ascending sort with integers' => [
-            'sortdir'  => 'asc',
-            'sortcol'  => 'column1',
-            'keys'     => [['info' => ['column1' => 3]], ['info' => ['column1' => 1]], ['info' => ['column1' => 2]],],
-            'expected' => [['info' => ['column1' => 1]], ['info' => ['column1' => 2]], ['info' => ['column1' => 3]],],
+            'asc',
+            'column1',
+            [['info' => ['column1' => 3]], ['info' => ['column1' => 1]], ['info' => ['column1' => 2]],],
+            [['info' => ['column1' => 1]], ['info' => ['column1' => 2]], ['info' => ['column1' => 3]],],
         ];
         yield 'descending sort with integers' => [
-            'sortdir'  => 'desc',
-            'sortcol'  => 'column1',
-            'keys'     => [['info' => ['column1' => 1]], ['info' => ['column1' => 2]], ['info' => ['column1' => 3]],],
-            'expected' => [['info' => ['column1' => 3]], ['info' => ['column1' => 2]], ['info' => ['column1' => 1]],],
+            'desc',
+            'column1',
+            [['info' => ['column1' => 1]], ['info' => ['column1' => 2]], ['info' => ['column1' => 3]],],
+            [['info' => ['column1' => 3]], ['info' => ['column1' => 2]], ['info' => ['column1' => 1]],],
         ];
     }