Skip to content

Commit 57c98f8

Browse files
authored
Apply suggestions from code review
1 parent 6e6a085 commit 57c98f8

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

content/en-us/reference/engine/classes/CollectionService.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ methods:
6060
- When tagging an instance, it is common that some resources
6161
are used to give the tag its functionality, for example event connections or
6262
tables. To prevent memory leaks, it's a good idea to clean these up
63-
(disconnect, set to nil, etc) when no longer needed for a tag. Do this
63+
(disconnect, set to `nil`, etc.) when no longer needed for a tag. Do this
6464
when calling `Class.CollectionService:RemoveTag()`, calling
6565
`Class.Instance:Destroy()` or in a function connected to a signal returned
6666
by `Class.CollectionService:GetInstanceRemovedSignal()`.

content/en-us/reference/engine/classes/Instance.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,9 +321,13 @@ methods:
321321
already applied. Successfully adding a tag will fire a signal created by
322322
`Class.CollectionService:GetInstanceAddedSignal()` with the given tag.
323323
324-
**Warning:** An instance's tags that were added client-side will be dropped if the server later adds or removes a tag on that instance, because the server replicates all tags together and overwrites previous tags.
324+
##### Warnings
325+
326+
- An instance's tags that were added client-side will be dropped if the server
327+
later adds or removes a tag on that instance, because the server replicates
328+
all tags together and overwrites previous tags.
325329
326-
Note that when tagging an instance, it's common that some resources are
330+
- When tagging an instance, it is common that some resources are
327331
used to give the tag its functionality, for example event connections or
328332
tables. To prevent memory leaks, it's a good idea to clean these up
329333
(disconnect, set to `nil`, etc.) when no longer needed for a tag. Do this

0 commit comments

Comments
 (0)