From a389bd65f88452a381381bd19e6acb2c1d732b98 Mon Sep 17 00:00:00 2001 From: ExtremePro11299 <134209046+ExtremePro11299@users.noreply.github.com> Date: Sat, 22 Mar 2025 19:18:16 +0100 Subject: [PATCH 1/7] Replace their with there --- content/en-us/reference/engine/classes/DataModelMesh.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/en-us/reference/engine/classes/DataModelMesh.yaml b/content/en-us/reference/engine/classes/DataModelMesh.yaml index 35359261b..295213369 100644 --- a/content/en-us/reference/engine/classes/DataModelMesh.yaml +++ b/content/en-us/reference/engine/classes/DataModelMesh.yaml @@ -96,10 +96,10 @@ properties: cylinder, using the lowest value. - `Class.SpecialMesh` objects with `Class.SpecialMesh.FileType` set to 'Head' currently scale in a non standard manner. Developers should not - rely on this as their are plans to change this behavior + rely on this as there are plans to change this behavior - `Class.SpecialMesh` objects with `Class.SpecialMesh.FileType` set to 'Torso' scale in a non standard manner. Developers should not rely on - this as their are plans to deprecate this mesh type. + this as there are plans to deprecate this mesh type. #### Mesh scale demonstration From 2d6ae47fe4c1660966f2056d96bacc733bcb595c Mon Sep 17 00:00:00 2001 From: ExtremePro11299 <134209046+ExtremePro11299@users.noreply.github.com> Date: Sat, 22 Mar 2025 20:11:45 +0100 Subject: [PATCH 2/7] Mention that Lighting.Technology cannot be accessed from Roblox Studio (#1) --- content/en-us/reference/engine/classes/Lighting.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/en-us/reference/engine/classes/Lighting.yaml b/content/en-us/reference/engine/classes/Lighting.yaml index 1bc2c2949..089476385 100644 --- a/content/en-us/reference/engine/classes/Lighting.yaml +++ b/content/en-us/reference/engine/classes/Lighting.yaml @@ -564,7 +564,7 @@ properties: . description: | Determines the lighting system for rendering the 3D world. This property - is non‑scriptable and only modifiable in Studio. See `Enum.Technology` for + is non‑scriptable and is no longer accessible in Roblox Studio. See `Enum.Technology` for available options and [Lighting Technology](../../../environment/lighting.md#technology) for detailed descriptions and visual effects of each option. From d1e495824a6d3c799078447994c9f839e44a81dc Mon Sep 17 00:00:00 2001 From: ExtremePro11299 <134209046+ExtremePro11299@users.noreply.github.com> Date: Sun, 23 Mar 2025 18:56:54 +0100 Subject: [PATCH 3/7] Redirect players to LightingStyle --- content/en-us/reference/engine/classes/Lighting.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/en-us/reference/engine/classes/Lighting.yaml b/content/en-us/reference/engine/classes/Lighting.yaml index 089476385..8f04128b2 100644 --- a/content/en-us/reference/engine/classes/Lighting.yaml +++ b/content/en-us/reference/engine/classes/Lighting.yaml @@ -413,7 +413,7 @@ properties: deprecation_message: '' security: read: None - write: None + write: StudioSecurity thread_safety: ReadSafe category: Appearance serialization: @@ -564,7 +564,7 @@ properties: . description: | Determines the lighting system for rendering the 3D world. This property - is non‑scriptable and is no longer accessible in Roblox Studio. See `Enum.Technology` for + is non‑scriptable and is no longer accessible in Roblox Studio. Use `Class.Lighting.LightingStyle|LightingStyle` instead. See `Enum.Technology` for available options and [Lighting Technology](../../../environment/lighting.md#technology) for detailed descriptions and visual effects of each option. From 271ad46e9a86643290da80d18dd508fa90c6be70 Mon Sep 17 00:00:00 2001 From: ExtremePro11299 <134209046+ExtremePro11299@users.noreply.github.com> Date: Sun, 23 Mar 2025 18:59:04 +0100 Subject: [PATCH 4/7] Undo changes to security --- content/en-us/reference/engine/classes/Lighting.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/en-us/reference/engine/classes/Lighting.yaml b/content/en-us/reference/engine/classes/Lighting.yaml index 8f04128b2..704fb9054 100644 --- a/content/en-us/reference/engine/classes/Lighting.yaml +++ b/content/en-us/reference/engine/classes/Lighting.yaml @@ -413,7 +413,7 @@ properties: deprecation_message: '' security: read: None - write: StudioSecurity + write: None thread_safety: ReadSafe category: Appearance serialization: From 5ff58a55332d2b4ae8f10ad2c4255584dad4170a Mon Sep 17 00:00:00 2001 From: ExtremePro11299 <134209046+ExtremePro11299@users.noreply.github.com> Date: Sun, 23 Mar 2025 19:39:43 +0100 Subject: [PATCH 5/7] Add summary to VideoService --- content/en-us/reference/engine/classes/VideoService.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/en-us/reference/engine/classes/VideoService.yaml b/content/en-us/reference/engine/classes/VideoService.yaml index 21615a7ff..5dea70554 100644 --- a/content/en-us/reference/engine/classes/VideoService.yaml +++ b/content/en-us/reference/engine/classes/VideoService.yaml @@ -2,7 +2,7 @@ name: VideoService type: class category: memory_category: Instances -summary: '' +summary: 'An internal service that offers no functionality to developers.' description: '' code_samples: [] inherits: From e45beb4e2d1ece13e17a22943a3416b8c678d651 Mon Sep 17 00:00:00 2001 From: IgnisRBX <43388550+IgnisRBX@users.noreply.github.com> Date: Mon, 24 Mar 2025 05:27:55 -1000 Subject: [PATCH 6/7] Apply suggestions from code review --- content/en-us/reference/engine/classes/DataModelMesh.yaml | 2 +- content/en-us/reference/engine/classes/VideoService.yaml | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/content/en-us/reference/engine/classes/DataModelMesh.yaml b/content/en-us/reference/engine/classes/DataModelMesh.yaml index 295213369..5f502063a 100644 --- a/content/en-us/reference/engine/classes/DataModelMesh.yaml +++ b/content/en-us/reference/engine/classes/DataModelMesh.yaml @@ -96,7 +96,7 @@ properties: cylinder, using the lowest value. - `Class.SpecialMesh` objects with `Class.SpecialMesh.FileType` set to 'Head' currently scale in a non standard manner. Developers should not - rely on this as there are plans to change this behavior + rely on this as there are plans to change this behavior. - `Class.SpecialMesh` objects with `Class.SpecialMesh.FileType` set to 'Torso' scale in a non standard manner. Developers should not rely on this as there are plans to deprecate this mesh type. diff --git a/content/en-us/reference/engine/classes/VideoService.yaml b/content/en-us/reference/engine/classes/VideoService.yaml index 5dea70554..8f14b6657 100644 --- a/content/en-us/reference/engine/classes/VideoService.yaml +++ b/content/en-us/reference/engine/classes/VideoService.yaml @@ -2,7 +2,8 @@ name: VideoService type: class category: memory_category: Instances -summary: 'An internal service that offers no functionality to developers.' +summary: | + An internal service that offers no functionality to developers. description: '' code_samples: [] inherits: From c6a8b175d9584f4e4eef52af68128545eb2fbca0 Mon Sep 17 00:00:00 2001 From: Andrew Etter Date: Mon, 24 Mar 2025 08:58:46 -0700 Subject: [PATCH 7/7] Update content/en-us/reference/engine/classes/Lighting.yaml --- content/en-us/reference/engine/classes/Lighting.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/en-us/reference/engine/classes/Lighting.yaml b/content/en-us/reference/engine/classes/Lighting.yaml index 704fb9054..1bc2c2949 100644 --- a/content/en-us/reference/engine/classes/Lighting.yaml +++ b/content/en-us/reference/engine/classes/Lighting.yaml @@ -564,7 +564,7 @@ properties: . description: | Determines the lighting system for rendering the 3D world. This property - is non‑scriptable and is no longer accessible in Roblox Studio. Use `Class.Lighting.LightingStyle|LightingStyle` instead. See `Enum.Technology` for + is non‑scriptable and only modifiable in Studio. See `Enum.Technology` for available options and [Lighting Technology](../../../environment/lighting.md#technology) for detailed descriptions and visual effects of each option.