Skip to content

Conversation

@PhoenixWhitefire
Copy link
Contributor

@PhoenixWhitefire PhoenixWhitefire commented Oct 30, 2025

Unfortunately, the section header for the Wikipedia page uses an em dash, not a hyphen.

Changes

Changes the underlying URL for "Tait-Bryan Angles" in the Orientation documentation for BaseParts to correctly use an em dash () like the Wikipedia article, instead of a hyphen (-). Using a hyphen prevents browsers from automatically scrolling to the correct section of the article. I have intentionally left the actual hyperlink text the same, as to maintain consistency with the Documentation's overall use of hyphens over em dashes.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

Unfortunately, the section header for the Wikipedia page uses an em dash, *not* a hyphen.
@PhoenixWhitefire PhoenixWhitefire requested a review from a team as a code owner October 30, 2025 11:09
@github-actions github-actions bot added engine reference Changes the Engine API Reference documentation changes requested This pull request has changes requested prior to merging labels Oct 30, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PhoenixWhitefire, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.

@PhoenixWhitefire
Copy link
Contributor Author

I'm going to assume that the CI is broken currently

@haan-roblox haan-roblox merged commit 23560de into Roblox:main Nov 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested This pull request has changes requested prior to merging engine reference Changes the Engine API Reference documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants