From 32db08c0ccf47b5212deca588f961acf2d5a52b3 Mon Sep 17 00:00:00 2001 From: T 'Filtered' C <132796135+metatablecat@users.noreply.github.com> Date: Fri, 6 Dec 2024 11:00:10 +0000 Subject: [PATCH 1/3] Link AdService to Immersive Ads --- .../en-us/reference/engine/classes/AdService.yaml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/content/en-us/reference/engine/classes/AdService.yaml b/content/en-us/reference/engine/classes/AdService.yaml index ff55006b1..c38bc0e95 100644 --- a/content/en-us/reference/engine/classes/AdService.yaml +++ b/content/en-us/reference/engine/classes/AdService.yaml @@ -5,8 +5,11 @@ memory_category: Instances summary: | A class that allows the display of mobile video ads. description: | - This **AdService** is a service for displaying mobile video ads as a form of + This **AdService** was a service for displaying mobile video ads as a form of monetization. + + It has been superseeded by [Immersive Ads](../../../production/monetization/immersive-ads) + which should be used instead to serve ad units to visitors of your experience. code_samples: inherits: - Instance @@ -31,8 +34,8 @@ methods: - Deprecated deprecation_message: | `Class.AdService` has been decommissioned and is no longer operational. - There is no replacement service and this event should not be used in new - work. + [Immersive Ads](../../../production/monetization/immersive-ads) should + be used as a replacement to `Class.AdService`. security: None thread_safety: Unsafe capabilities: [] @@ -53,8 +56,8 @@ events: - Deprecated deprecation_message: | `Class.AdService` has been decommissioned and is no longer operational. - There is no replacement service and this event should not be used in new - work. + [Immersive Ads](../../../production/monetization/immersive-ads) should + be used as a replacement to `Class.AdService`. security: None thread_safety: Unsafe capabilities: [] From 09c52dc571dfcd32104594f0b5830123c173060f Mon Sep 17 00:00:00 2001 From: T 'Filtered' C <132796135+metatablecat@users.noreply.github.com> Date: Fri, 6 Dec 2024 11:02:58 +0000 Subject: [PATCH 2/3] Fix link anchor --- content/en-us/reference/engine/classes/AdService.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/content/en-us/reference/engine/classes/AdService.yaml b/content/en-us/reference/engine/classes/AdService.yaml index c38bc0e95..eb77a8c8a 100644 --- a/content/en-us/reference/engine/classes/AdService.yaml +++ b/content/en-us/reference/engine/classes/AdService.yaml @@ -8,7 +8,7 @@ description: | This **AdService** was a service for displaying mobile video ads as a form of monetization. - It has been superseeded by [Immersive Ads](../../../production/monetization/immersive-ads) + It has been superseeded by [Immersive Ads](../../../production/monetization/immersive-ads.md) which should be used instead to serve ad units to visitors of your experience. code_samples: inherits: @@ -34,7 +34,7 @@ methods: - Deprecated deprecation_message: | `Class.AdService` has been decommissioned and is no longer operational. - [Immersive Ads](../../../production/monetization/immersive-ads) should + [Immersive Ads](../../../production/monetization/immersive-ads.md) should be used as a replacement to `Class.AdService`. security: None thread_safety: Unsafe @@ -56,7 +56,7 @@ events: - Deprecated deprecation_message: | `Class.AdService` has been decommissioned and is no longer operational. - [Immersive Ads](../../../production/monetization/immersive-ads) should + [Immersive Ads](../../../production/monetization/immersive-ads.md) should be used as a replacement to `Class.AdService`. security: None thread_safety: Unsafe From ebf809fcf682fe35603ba9f4788438e64172d2c1 Mon Sep 17 00:00:00 2001 From: IgnisRBX <43388550+IgnisRBX@users.noreply.github.com> Date: Fri, 6 Dec 2024 06:33:13 -1000 Subject: [PATCH 3/3] Apply suggestions from code review --- content/en-us/reference/engine/classes/AdService.yaml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/content/en-us/reference/engine/classes/AdService.yaml b/content/en-us/reference/engine/classes/AdService.yaml index eb77a8c8a..77747c744 100644 --- a/content/en-us/reference/engine/classes/AdService.yaml +++ b/content/en-us/reference/engine/classes/AdService.yaml @@ -5,10 +5,8 @@ memory_category: Instances summary: | A class that allows the display of mobile video ads. description: | - This **AdService** was a service for displaying mobile video ads as a form of - monetization. - - It has been superseeded by [Immersive Ads](../../../production/monetization/immersive-ads.md) + This `Class.AdService` was a service for displaying mobile video ads as a form of + monetization. It has been superseded by [Immersive Ads](../../../production/monetization/immersive-ads.md) which should be used instead to serve ad units to visitors of your experience. code_samples: inherits: @@ -35,7 +33,7 @@ methods: deprecation_message: | `Class.AdService` has been decommissioned and is no longer operational. [Immersive Ads](../../../production/monetization/immersive-ads.md) should - be used as a replacement to `Class.AdService`. + be used as a replacement for `Class.AdService`. security: None thread_safety: Unsafe capabilities: [] @@ -57,7 +55,7 @@ events: deprecation_message: | `Class.AdService` has been decommissioned and is no longer operational. [Immersive Ads](../../../production/monetization/immersive-ads.md) should - be used as a replacement to `Class.AdService`. + be used as a replacement for `Class.AdService`. security: None thread_safety: Unsafe capabilities: []