From f6af1da9c31d35b11ca4a1bc8e2af9181325e334 Mon Sep 17 00:00:00 2001 From: ramdoys Date: Sun, 22 Dec 2024 00:30:58 -0500 Subject: [PATCH 1/9] fix: update game.Players to game:GetService("Players") --- content/en-us/production/monetization/developer-products.md | 2 +- content/en-us/reference/engine/classes/Backpack.yaml | 4 ++-- content/en-us/reference/engine/classes/GuiObject.yaml | 2 +- content/en-us/reference/engine/classes/Object.yaml | 2 +- content/en-us/reference/engine/classes/Tool.yaml | 4 ++-- content/en-us/reference/engine/classes/Translator.yaml | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/content/en-us/production/monetization/developer-products.md b/content/en-us/production/monetization/developer-products.md index 6a94a6f3c..c5534330d 100644 --- a/content/en-us/production/monetization/developer-products.md +++ b/content/en-us/production/monetization/developer-products.md @@ -113,7 +113,7 @@ You can also combine functions inside a `Class.LocalScript|LocalScript`. For exa ```lua local MarketplaceService = game:GetService("MarketplaceService") -local player = game.Players.LocalPlayer +local player = game:GetSerivce("Players").LocalPlayer local button = script.Parent -- Replace the placeholder ID with your developer product ID diff --git a/content/en-us/reference/engine/classes/Backpack.yaml b/content/en-us/reference/engine/classes/Backpack.yaml index d3e25f6ba..a60f95db7 100644 --- a/content/en-us/reference/engine/classes/Backpack.yaml +++ b/content/en-us/reference/engine/classes/Backpack.yaml @@ -30,10 +30,10 @@ description: | ```lua -- Accessing Backpack from a Server Script: - game.Players.PlayerName.Backpack + game:GetSerivce("Players").PlayerName.Backpack -- Accessing Backpack from a LocalScript: - game.Players.LocalPlayer.Backpack + game:GetSerivce("Players").LocalPlayer.Backpack ``` code_samples: - Backpack-Give-Tool diff --git a/content/en-us/reference/engine/classes/GuiObject.yaml b/content/en-us/reference/engine/classes/GuiObject.yaml index 2b3009ff0..270c56d21 100644 --- a/content/en-us/reference/engine/classes/GuiObject.yaml +++ b/content/en-us/reference/engine/classes/GuiObject.yaml @@ -1422,7 +1422,7 @@ events: local CustomScrollingFrame = script.Parent local SubFrame = CustomScrollingFrame:FindFirstChild("SubFrame") - local mouse = game.Players.LocalPlayer:GetMouse() + local mouse = game:GetSerivce("Players").LocalPlayer:GetMouse() function getPosition(X, Y) local gui_X = CustomScrollingFrame.AbsolutePosition.X local gui_Y = CustomScrollingFrame.AbsolutePosition.Y diff --git a/content/en-us/reference/engine/classes/Object.yaml b/content/en-us/reference/engine/classes/Object.yaml index 2b6c4b37d..dceac7410 100644 --- a/content/en-us/reference/engine/classes/Object.yaml +++ b/content/en-us/reference/engine/classes/Object.yaml @@ -165,7 +165,7 @@ methods: end end end - paintFigure(game.Players.Player.Character, BrickColor.new("Bright blue")) + paintFigure(game:GetSerivce("Players").Player.Character, BrickColor.new("Bright blue")) ``` Since all classes inherit from `Class.Object`, calling diff --git a/content/en-us/reference/engine/classes/Tool.yaml b/content/en-us/reference/engine/classes/Tool.yaml index 9ab17daf0..c8a0c37d8 100644 --- a/content/en-us/reference/engine/classes/Tool.yaml +++ b/content/en-us/reference/engine/classes/Tool.yaml @@ -393,7 +393,7 @@ events: ```lua local tool = Instance.new("Tool") tool.RequiresHandle = false - tool.Parent = game.Players.LocalPlayer.Backpack + tool.Parent = game:GetSerivce("Players").LocalPlayer.Backpack function onActivation() print("Tool activated") @@ -425,7 +425,7 @@ events: ```lua local tool = Instance.new("Tool") tool.RequiresHandle = false - tool.Parent = game.Players.LocalPlayer.Backpack + tool.Parent = game:GetSerivce("Players").LocalPlayer.Backpack function toolDeactivated() print("Tool deactivated") diff --git a/content/en-us/reference/engine/classes/Translator.yaml b/content/en-us/reference/engine/classes/Translator.yaml index 8c38175ad..9c2867821 100644 --- a/content/en-us/reference/engine/classes/Translator.yaml +++ b/content/en-us/reference/engine/classes/Translator.yaml @@ -212,7 +212,7 @@ methods: local LocalizationService = game:GetService("LocalizationService") local success, translator = pcall(function() - return LocalizationService:GetTranslatorForPlayerAsync(game.Players.LocalPlayer) + return LocalizationService:GetTranslatorForPlayerAsync(game:GetSerivce("Players").LocalPlayer) end) if success then From bca4f635854061b9cf5cad40c8fbd889250da64c Mon Sep 17 00:00:00 2001 From: IgnisRBX <43388550+IgnisRBX@users.noreply.github.com> Date: Mon, 6 Jan 2025 08:32:10 -1000 Subject: [PATCH 2/9] Apply suggestions from code review --- content/en-us/production/monetization/developer-products.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/content/en-us/production/monetization/developer-products.md b/content/en-us/production/monetization/developer-products.md index c5534330d..bd77f4f87 100644 --- a/content/en-us/production/monetization/developer-products.md +++ b/content/en-us/production/monetization/developer-products.md @@ -113,7 +113,9 @@ You can also combine functions inside a `Class.LocalScript|LocalScript`. For exa ```lua local MarketplaceService = game:GetService("MarketplaceService") -local player = game:GetSerivce("Players").LocalPlayer +local Players = game:GetService("Players") + +local player = Players.LocalPlayer local button = script.Parent -- Replace the placeholder ID with your developer product ID From 36790467b7b990e46367cbb02fc41fb286323a0f Mon Sep 17 00:00:00 2001 From: IgnisRBX <43388550+IgnisRBX@users.noreply.github.com> Date: Mon, 6 Jan 2025 08:35:52 -1000 Subject: [PATCH 3/9] Update content/en-us/reference/engine/classes/Backpack.yaml --- content/en-us/reference/engine/classes/Backpack.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content/en-us/reference/engine/classes/Backpack.yaml b/content/en-us/reference/engine/classes/Backpack.yaml index a60f95db7..bb26eabe8 100644 --- a/content/en-us/reference/engine/classes/Backpack.yaml +++ b/content/en-us/reference/engine/classes/Backpack.yaml @@ -29,6 +29,8 @@ description: | The Backpack can be accessed from both the client and the server. ```lua + local Players = game:GetService("Players") + -- Accessing Backpack from a Server Script: game:GetSerivce("Players").PlayerName.Backpack From 6f95357b72db4f2f627cebf6992c2ab77773dd80 Mon Sep 17 00:00:00 2001 From: IgnisRBX <43388550+IgnisRBX@users.noreply.github.com> Date: Mon, 6 Jan 2025 08:35:59 -1000 Subject: [PATCH 4/9] Update content/en-us/reference/engine/classes/Backpack.yaml --- content/en-us/reference/engine/classes/Backpack.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/en-us/reference/engine/classes/Backpack.yaml b/content/en-us/reference/engine/classes/Backpack.yaml index bb26eabe8..2b8ff581a 100644 --- a/content/en-us/reference/engine/classes/Backpack.yaml +++ b/content/en-us/reference/engine/classes/Backpack.yaml @@ -32,7 +32,7 @@ description: | local Players = game:GetService("Players") -- Accessing Backpack from a Server Script: - game:GetSerivce("Players").PlayerName.Backpack + local backpack = Players.PlayerName.Backpack -- Accessing Backpack from a LocalScript: game:GetSerivce("Players").LocalPlayer.Backpack From 42432ea34ea8380ab1c8bdab02dede4b19c8fe4b Mon Sep 17 00:00:00 2001 From: IgnisRBX <43388550+IgnisRBX@users.noreply.github.com> Date: Mon, 6 Jan 2025 08:36:04 -1000 Subject: [PATCH 5/9] Update content/en-us/reference/engine/classes/Backpack.yaml --- content/en-us/reference/engine/classes/Backpack.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/en-us/reference/engine/classes/Backpack.yaml b/content/en-us/reference/engine/classes/Backpack.yaml index 2b8ff581a..6e06f0f1b 100644 --- a/content/en-us/reference/engine/classes/Backpack.yaml +++ b/content/en-us/reference/engine/classes/Backpack.yaml @@ -35,7 +35,7 @@ description: | local backpack = Players.PlayerName.Backpack -- Accessing Backpack from a LocalScript: - game:GetSerivce("Players").LocalPlayer.Backpack + local backpack = Players.LocalPlayer.Backpack ``` code_samples: - Backpack-Give-Tool From bde4c37173d93af413b7154321409da1be7597ad Mon Sep 17 00:00:00 2001 From: IgnisRBX <43388550+IgnisRBX@users.noreply.github.com> Date: Mon, 6 Jan 2025 08:48:30 -1000 Subject: [PATCH 6/9] Apply suggestions from code review --- content/en-us/reference/engine/classes/GuiObject.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/content/en-us/reference/engine/classes/GuiObject.yaml b/content/en-us/reference/engine/classes/GuiObject.yaml index e857b0326..8fb06c5ef 100644 --- a/content/en-us/reference/engine/classes/GuiObject.yaml +++ b/content/en-us/reference/engine/classes/GuiObject.yaml @@ -1417,11 +1417,14 @@ events: of the user's mouse relative to a GUI element: ```lua + local Players = game:GetService("Players") + local CustomScrollingFrame = script.Parent local SubFrame = CustomScrollingFrame:FindFirstChild("SubFrame") - local mouse = game:GetSerivce("Players").LocalPlayer:GetMouse() - function getPosition(X, Y) + local mouse = Players.LocalPlayer:GetMouse() + + local function getPosition(X, Y) local gui_X = CustomScrollingFrame.AbsolutePosition.X local gui_Y = CustomScrollingFrame.AbsolutePosition.Y From 2d1f23d26bdd4ab28c72883e595ce0e8b0a31871 Mon Sep 17 00:00:00 2001 From: IgnisRBX <43388550+IgnisRBX@users.noreply.github.com> Date: Mon, 6 Jan 2025 08:53:11 -1000 Subject: [PATCH 7/9] Apply suggestions from code review --- content/en-us/reference/engine/classes/Tool.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/content/en-us/reference/engine/classes/Tool.yaml b/content/en-us/reference/engine/classes/Tool.yaml index c8a0c37d8..08441b7a9 100644 --- a/content/en-us/reference/engine/classes/Tool.yaml +++ b/content/en-us/reference/engine/classes/Tool.yaml @@ -391,9 +391,11 @@ events: player clicks while the created tool is equipped. ```lua + local Players = game:GetService("Players") + local tool = Instance.new("Tool") tool.RequiresHandle = false - tool.Parent = game:GetSerivce("Players").LocalPlayer.Backpack + tool.Parent = Players.LocalPlayer.Backpack function onActivation() print("Tool activated") @@ -423,9 +425,11 @@ events: player releases their click while the tool is equipped and activated. ```lua + local Players = game:GetService("Players") + local tool = Instance.new("Tool") tool.RequiresHandle = false - tool.Parent = game:GetSerivce("Players").LocalPlayer.Backpack + tool.Parent = Players.LocalPlayer.Backpack function toolDeactivated() print("Tool deactivated") From 3f40175013ee5bd8076518a84741815cb98d2a49 Mon Sep 17 00:00:00 2001 From: IgnisRBX <43388550+IgnisRBX@users.noreply.github.com> Date: Mon, 6 Jan 2025 08:59:19 -1000 Subject: [PATCH 8/9] Apply suggestions from code review --- content/en-us/reference/engine/classes/Translator.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/content/en-us/reference/engine/classes/Translator.yaml b/content/en-us/reference/engine/classes/Translator.yaml index 9c2867821..1630e3105 100644 --- a/content/en-us/reference/engine/classes/Translator.yaml +++ b/content/en-us/reference/engine/classes/Translator.yaml @@ -209,10 +209,11 @@ methods: text as the second argument: ```lua + local Players = game:GetService("Players") local LocalizationService = game:GetService("LocalizationService") local success, translator = pcall(function() - return LocalizationService:GetTranslatorForPlayerAsync(game:GetSerivce("Players").LocalPlayer) + return LocalizationService:GetTranslatorForPlayerAsync(Players.LocalPlayer) end) if success then From 5cd7e5e32011ffb983bed372a2830fa4a1e51675 Mon Sep 17 00:00:00 2001 From: IgnisRBX <43388550+IgnisRBX@users.noreply.github.com> Date: Mon, 6 Jan 2025 09:00:58 -1000 Subject: [PATCH 9/9] Update Object.yaml --- content/en-us/reference/engine/classes/Object.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/content/en-us/reference/engine/classes/Object.yaml b/content/en-us/reference/engine/classes/Object.yaml index dceac7410..8e7e9dc65 100644 --- a/content/en-us/reference/engine/classes/Object.yaml +++ b/content/en-us/reference/engine/classes/Object.yaml @@ -155,6 +155,8 @@ methods: `Datatype.BrickColor` property: ```lua + local Players = game:GetService("Players") + local function paintFigure(character, color) -- Iterate over the child objects of the character for _, child in character:GetChildren() do @@ -165,7 +167,7 @@ methods: end end end - paintFigure(game:GetSerivce("Players").Player.Character, BrickColor.new("Bright blue")) + paintFigure(Players.Player.Character, BrickColor.new("Bright blue")) ``` Since all classes inherit from `Class.Object`, calling