Skip to content

Commit 7a037d9

Browse files
authored
Use group status to report exit code (#41)
1 parent c0eece4 commit 7a037d9

File tree

4 files changed

+54
-18
lines changed

4 files changed

+54
-18
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
## Unreleased Changes
44

5+
- Report correct exit code ([#41](https://github.com/Roblox/foreman/pull/41))
56
- Improve error handling to reduces crashes and add more useful error messages ([#40](https://github.com/Roblox/foreman/pull/40))
67
- Add environment variable to override Foreman home directory ([#39](https://github.com/Roblox/foreman/pull/39))
78
- Support tools hosted on GitLab ([#31](https://github.com/Roblox/foreman/pull/31))

Cargo.lock

Lines changed: 50 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ edition = "2018"
1515
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
1616

1717
[dependencies]
18+
command-group = "1.0.8"
1819
dirs = "4.0.0"
1920
env_logger = "0.9.0"
2021
log = "0.4.14"

src/tool_cache.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ use std::{
66
process,
77
};
88

9+
use command_group::CommandGroup;
910
use semver::Version;
1011
use serde::{Deserialize, Serialize};
1112
use zip::ZipArchive;
@@ -36,7 +37,7 @@ impl ToolCache {
3637

3738
let status = process::Command::new(&tool_path)
3839
.args(args)
39-
.status()
40+
.group_status()
4041
.map_err(|err| {
4142
ForemanError::io_error_with_context(err,
4243
format!(

0 commit comments

Comments
 (0)