Fix tools execution (#38)

Author: oltrep

.github/workflows/ci.yml

@@ -10,8 +10,19 @@ on:
     - master
 
 jobs:
-  build:
+  checks:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: Rustfmt
+      run: cargo fmt -- --check
+
+    - name: Clippy
+      run: cargo clippy
 
+  build:
     runs-on: ubuntu-latest
 
     strategy:
@@ -30,8 +41,16 @@ jobs:
     - name: Run tests
       run: cargo test --locked --verbose
 
-    - name: Rustfmt and Clippy
+  end-to-end-tests:
+    runs-on: ubuntu-latest
+    needs: build
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: End-to-end tests
       run: |
-        cargo fmt -- --check
-        cargo clippy
-      if: matrix.rust_version == 'stable'
+        cargo install --path .
+        foreman --version
+        PATH=$PATH:~/.foreman/bin
+        ./scripts/end-to-end-tests.sh

scripts/end-to-end-tests.sh

@@ -0,0 +1,46 @@
+#!/bin/bash
+
+set -e
+
+verify_tool_version () {
+    echo "verify tool" $1
+    TOOL_VERSION=$($1 -V)
+
+    if [[ $TOOL_VERSION != "$1 $2" ]]; then
+        echo "version did not match:" $TOOL_VERSION
+        exit 1
+    else
+        echo $1 "is there!"
+    fi
+}
+
+write_foreman_toml () {
+    echo "[tools]" > foreman.toml
+    echo "$2 = { $1 = \"$3\", version = \"=$4\" }" >> foreman.toml
+}
+
+verify_github_tool () {
+    write_foreman_toml github $1 $2 $3
+    foreman install
+    verify_tool_version $1 $3
+    rm foreman.toml
+
+    # for compatibility, verify that `source` also works
+    write_foreman_toml source $1 $2 $3
+    foreman install
+    verify_tool_version $1 $3
+    rm foreman.toml
+}
+
+verify_gitlab_tool () {
+    write_foreman_toml gitlab $1 $2 $3
+    foreman install
+    verify_tool_version $1 $3
+    rm foreman.toml
+}
+
+verify_github_tool Rojo "rojo-rbx/rojo" "6.0.0"
+verify_github_tool remodel "rojo-rbx/remodel" "0.9.1"
+verify_github_tool stylua "JohnnyMorganz/stylua" "0.11.3"
+
+verify_gitlab_tool darklua "seaofvoices/darklua" "0.7.0"

src/main.rs

@@ -39,28 +39,16 @@ impl ToolInvocation {
 }
 
 fn main() -> Result<(), Box<dyn Error>> {
-    let app = Options::from_args();
-
-    {
-        let log_filter = match app.verbose {
-            0 => "warn,foreman=info",
-            1 => "info,foreman=debug",
-            2 => "info,foreman=trace",
-            _ => "trace",
-        };
-
-        let env = env_logger::Env::default().default_filter_or(log_filter);
+    paths::create()?;
 
+    if let Some(invocation) = ToolInvocation::from_env() {
+        let env = env_logger::Env::new().default_filter_or("foreman=info");
         env_logger::Builder::from_env(env)
             .format_module_path(false)
             .format_timestamp(None)
             .format_indent(Some(8))
             .init();
-    }
 
-    paths::create()?;
-
-    if let Some(invocation) = ToolInvocation::from_env() {
         let config = ConfigFile::aggregate()?;
 
         if let Some(tool_spec) = config.tools.get(&invocation.name) {
@@ -145,6 +133,23 @@ struct GitLabAuthCommand {
 fn actual_main() -> io::Result<()> {
     let options = Options::from_args();
 
+    {
+        let log_filter = match options.verbose {
+            0 => "warn,foreman=info",
+            1 => "info,foreman=debug",
+            2 => "info,foreman=trace",
+            _ => "trace",
+        };
+
+        let env = env_logger::Env::default().default_filter_or(log_filter);
+
+        env_logger::Builder::from_env(env)
+            .format_module_path(false)
+            .format_timestamp(None)
+            .format_indent(Some(8))
+            .init();
+    }
+
     match options.subcommand {
         Subcommand::Install => {
             let config = ConfigFile::aggregate()?;