[bugfix] Fix unit test

Author: g3force

internal/app/controller/engine.go

@@ -37,7 +37,7 @@ func NewGameControllerState() (s *GameControllerState) {
 		s.GameEventBehavior[event] = GameEventBehaviorOn
 	}
 
-	s.GameEventProposals = []*GameEventProposal{}
+	s.GameEventProposals = nil
 
 	s.AutoRefsConnected = []string{}
 	s.TeamConnected = map[Team]bool{}
@@ -53,8 +53,12 @@ func NewGameControllerState() (s *GameControllerState) {
 
 func (s GameControllerState) DeepCopy() (c GameControllerState) {
 	c = s
-	c.GameEventProposals = make([]*GameEventProposal, len(s.GameEventProposals))
-	copy(c.GameEventProposals, s.GameEventProposals)
+	if len(s.GameEventProposals) > 0 {
+		c.GameEventProposals = make([]*GameEventProposal, len(s.GameEventProposals))
+		copy(c.GameEventProposals, s.GameEventProposals)
+	} else {
+		c.GameEventProposals = nil
+	}
 	c.GameEventBehavior = make(map[GameEventType]GameEventBehavior)
 	for k, v := range s.GameEventBehavior {
 		c.GameEventBehavior[k] = v
@@ -238,7 +242,7 @@ func (e *Engine) SendCommand(command RefCommand, forTeam Team) {
 		}
 		// reset game event proposals
 		if len(e.GcState.GameEventProposals) > 0 {
-			e.GcState.GameEventProposals = []*GameEventProposal{}
+			e.GcState.GameEventProposals = nil
 		}
 		// reset ball placement pos and follow ups
 		e.State.PlacementPos = nil

internal/app/controller/engine_test.go

@@ -14,24 +14,21 @@ import (
 )
 
 type TestState struct {
-	Stage                      *Stage                               `yaml:"stage"`
-	Command                    *RefCommand                          `yaml:"command"`
-	CommandFor                 *Team                                `yaml:"commandFor"`
-	GameEvents                 []*GameEvent                         `yaml:"gameEvents"`
-	StageTimeElapsed           *time.Duration                       `yaml:"stageTimeElapsed"`
-	StageTimeLeft              *time.Duration                       `yaml:"stageTimeLeft"`
-	MatchTimeStart             *time.Time                           `yaml:"matchTimeStart"`
-	MatchDuration              *time.Duration                       `yaml:"matchDuration"`
-	TeamState                  map[Team]*TestTeamInfo               `yaml:"teamState"`
-	Division                   *config.Division                     `yaml:"division"`
-	PlacementPos               *Location                            `yaml:"placementPos"`
-	AutoContinue               *bool                                `yaml:"autoContinue"`
-	NextCommand                *RefCommand                          `yaml:"nextCommand"`
-	NextCommandFor             *Team                                `yaml:"nextCommandFor"`
-	GameEventBehavior          *map[GameEventType]GameEventBehavior `yaml:"gameEventBehavior"`
-	GameEventProposals         []*GameEventProposal                 `yaml:"gameEventProposals"`
-	CurrentActionDeadline      *time.Time                           `yaml:"currentActionDeadline"`
-	CurrentActionTimeRemaining *time.Duration                       `yaml:"currentActionTimeRemaining"`
+	Stage                      *Stage                 `yaml:"stage"`
+	Command                    *RefCommand            `yaml:"command"`
+	CommandFor                 *Team                  `yaml:"commandFor"`
+	GameEvents                 []*GameEvent           `yaml:"gameEvents"`
+	StageTimeElapsed           *time.Duration         `yaml:"stageTimeElapsed"`
+	StageTimeLeft              *time.Duration         `yaml:"stageTimeLeft"`
+	MatchTimeStart             *time.Time             `yaml:"matchTimeStart"`
+	MatchDuration              *time.Duration         `yaml:"matchDuration"`
+	TeamState                  map[Team]*TestTeamInfo `yaml:"teamState"`
+	Division                   *config.Division       `yaml:"division"`
+	PlacementPos               *Location              `yaml:"placementPos"`
+	NextCommand                *RefCommand            `yaml:"nextCommand"`
+	NextCommandFor             *Team                  `yaml:"nextCommandFor"`
+	CurrentActionDeadline      *time.Time             `yaml:"currentActionDeadline"`
+	CurrentActionTimeRemaining *time.Duration         `yaml:"currentActionTimeRemaining"`
 }
 
 type TestTeamInfo struct {
@@ -208,21 +205,6 @@ func (t *TestState) valid() error {
 	if t.NextCommandFor != nil && !t.NextCommandFor.Valid() {
 		return errors.Errorf("TestState.NextCommandFor has an invalid value: %v", t.NextCommandFor)
 	}
-	if t.GameEventBehavior != nil {
-		for gameEventType, gameEventBehavior := range *t.GameEventBehavior {
-			if !gameEventType.Valid() {
-				return errors.Errorf("TestState.GameEventBehavior has an invalid key: %v", gameEventType)
-			}
-			if !gameEventBehavior.Valid() {
-				return errors.Errorf("TestState.GameEventBehavior[%v] has an invalid value: %v", gameEventType, gameEventBehavior)
-			}
-		}
-	}
-	for _, proposal := range t.GameEventProposals {
-		if !proposal.GameEvent.Type.Valid() {
-			return errors.Errorf("TestState.GameEventProposals.GameEvent.Type has an invalid value: %v", proposal.GameEvent.Type)
-		}
-	}
 	return nil
 }