Bugfix: Only publish yellow card times >= 0

g3force · g3force · commit 2857cba18222 · 2020-04-26T20:27:56.000+02:00
diff --git a/internal/app/publish/datamapper.go b/internal/app/publish/datamapper.go
@@ -57,12 +57,11 @@ func commandByTeam(team state.Team, blueCommand state.Referee_Command, yellowCom
 	return -1
 }
 
-func mapYellowCardTimes(cards []*state.YellowCard) []uint32 {
-	times := make([]uint32, len(cards))
-	for i, c := range cards {
+func mapYellowCardTimes(cards []*state.YellowCard) (times []uint32) {
+	for _, c := range cards {
 		duration, _ := ptypes.Duration(c.TimeRemaining)
 		if duration > 0 {
-			times[i] = mapTime(duration)
+			times = append(times, mapTime(duration))
 		}
 	}
 	return times

Original file line number	Diff line number	Diff line change
`@@ -57,12 +57,11 @@ func commandByTeam(team state.Team, blueCommand state.Referee_Command, yellowCom`
`57`	`57`	`return -1`
`58`	`58`	`}`
`59`	`59`
`60`		`-func mapYellowCardTimes(cards []*state.YellowCard) []uint32 {`
`61`		`- times := make([]uint32, len(cards))`
`62`		`- for i, c := range cards {`
	`60`	`+func mapYellowCardTimes(cards []*state.YellowCard) (times []uint32) {`
	`61`	`+ for _, c := range cards {`
`63`	`62`	`duration, _ := ptypes.Duration(c.TimeRemaining)`
`64`	`63`	`if duration > 0 {`
`65`		`- times[i] = mapTime(duration)`
	`64`	`+ times = append(times, mapTime(duration))`
`66`	`65`	`}`
`67`	`66`	`}`
`68`	`67`	`return times`