[bugfix] Fix unit tests

Author: g3force

internal/app/controller/engine.go

@@ -690,6 +690,9 @@ func (e *Engine) updateNextCommandForStage() {
 	case StageSecondHalfPre, StageOvertimeSecondHalfPre:
 		e.State.NextCommand = CommandKickoff
 		e.State.NextCommandFor = e.GcState.FirstKickoffTeam.Opposite()
+	default:
+		e.State.NextCommand = ""
+		e.State.NextCommandFor = ""
 	}
 }
 

internal/app/controller/engine_test.go

@@ -112,6 +112,8 @@ func processTransitionFile(t *testing.T, fileName string) {
 		t.Fatal(err)
 	}
 	stateTransitions.InitialState.applyTo(e.GcState)
+	e.updateNextCommandForStage()
+
 	// initialize the expected state with the current engine state
 	expectedState := e.GcState.DeepCopy()
 

internal/app/controller/testdata/engine_test_command_kickoff.yaml

@@ -8,6 +8,8 @@ transitions:
         type: stop
     expectedStateDiff:
       command: stop
+      nextCommand: kickoff
+      nextCommandFor: Yellow
   - event:
       command:
         type: kickoff
@@ -16,6 +18,7 @@ transitions:
       command: kickoff
       commandFor: Yellow
       nextCommand: normalStart
+      nextCommandFor: ""
   - event:
       command:
         type: normalStart

internal/app/controller/testdata/engine_test_gameevent_kickoff.yaml

@@ -8,6 +8,8 @@ transitions:
         type: stop
     expectedStateDiff:
       command: stop
+      nextCommand: kickoff
+      nextCommandFor: Yellow
   - tick: 1s # make sure that the stage time is not proceeded
   - event:
       command:
@@ -17,6 +19,7 @@ transitions:
       command: kickoff
       commandFor: Blue
       nextCommand: normalStart
+      nextCommandFor: ""
   - event:
       gameEvent:
         type: prepared

internal/app/controller/testdata/engine_test_stage_full_forward.yaml

@@ -10,6 +10,8 @@ transitions:
       stage: First Half
       stageTimeLeft: 5m
       matchTimeStart: "2010-01-01T00:00:00Z"
+      nextCommand: ""
+      nextCommandFor: ""
   - event:
       stage:
         stageOperation: next
@@ -22,12 +24,16 @@ transitions:
     expectedStateDiff:
       stage: Pre-Second Half
       stageTimeLeft: 0
+      nextCommand: kickoff
+      nextCommandFor: Blue
   - event:
       stage:
         stageOperation: next
     expectedStateDiff:
       stage: Second Half
       stageTimeLeft: 5m
+      nextCommand: ""
+      nextCommandFor: ""
   - event:
       stage:
         stageOperation: next
@@ -40,6 +46,8 @@ transitions:
     expectedStateDiff:
       stage: Pre-Overtime First Half
       stageTimeLeft: 0
+      nextCommand: kickoff
+      nextCommandFor: Yellow
       teamState:
         Blue:
           timeoutsLeft: 2
@@ -51,6 +59,8 @@ transitions:
     expectedStateDiff:
       stage: Overtime First Half
       stageTimeLeft: 2m30s
+      nextCommand: ""
+      nextCommandFor: ""
   - event:
       stage:
         stageOperation: next
@@ -63,12 +73,16 @@ transitions:
     expectedStateDiff:
       stage: Pre-Overtime Second Half
       stageTimeLeft: 0
+      nextCommand: kickoff
+      nextCommandFor: Blue
   - event:
       stage:
         stageOperation: next
     expectedStateDiff:
       stage: Overtime Second Half
       stageTimeLeft: 2m30s
+      nextCommand: ""
+      nextCommandFor: ""
   - event:
       stage:
         stageOperation: next