[refactoring] Improve error handling

Author: g3force

internal/app/controller/controller.go

@@ -35,7 +35,7 @@ func NewGameController() (c *GameController) {
 
 	c = new(GameController)
 	c.Config = loadConfig()
-	c.Publisher = loadPublisher(c.Config)
+	c.Publisher = NewPublisher(c.Config.Network.PublishAddress)
 	c.ApiServer = ApiServer{}
 	c.ApiServer.Consumer = c
 
@@ -174,15 +174,6 @@ func (c *GameController) OnNewEvent(event Event) {
 	}
 }
 
-// loadPublisher creates a new publisher for multicast
-func loadPublisher(config config.Controller) Publisher {
-	publisher, err := NewPublisher(config.Network.PublishAddress)
-	if err != nil {
-		log.Printf("Could not start publisher on %v. %v", config.Network.PublishAddress, err)
-	}
-	return publisher
-}
-
 // loadConfig loads the controller config
 func loadConfig() config.Controller {
 	cfg, err := config.LoadControllerConfig(configFileName)

internal/app/controller/publisher.go

@@ -23,29 +23,31 @@ type RefMessage struct {
 }
 
 // NewPublisher creates a new publisher that publishes referee messages via UDP to the teams
-func NewPublisher(address string) (publisher Publisher, err error) {
+func NewPublisher(address string) (publisher Publisher) {
 
 	publisher.address = address
 
 	// initialize default referee message
 	publisher.message = RefMessage{send: publisher.send, referee: new(refproto.Referee)}
 	initRefereeMessage(publisher.message.referee)
 
-	err = publisher.connect()
+	publisher.connect()
 
 	return
 }
 
-func (p *Publisher) connect() (err error) {
+func (p *Publisher) connect() {
 	p.conn = nil
 
 	addr, err := net.ResolveUDPAddr("udp", p.address)
 	if err != nil {
+		log.Printf("Could not resolve address '%v': %v", p.address, err)
 		return
 	}
 
 	conn, err := net.DialUDP("udp", nil, addr)
 	if err != nil {
+		log.Printf("Could not connect to '%v': %v", addr, err)
 		return
 	}