Do not randomize team during majority

If a majority by type was reached, but no unique team could be agreed on, a team was drawn by chance.
Now, the team is set to unknown. Thus, the GCO has to manually choose how to proceed.

Author: g3force

internal/app/statemachine/change_acceptproposal.go

@@ -62,8 +62,7 @@ func (s *StateMachine) createMergedGameEvent(group *state.ProposalGroup, accepte
 	} else if byTeam[state.Team_YELLOW] < byTeam[state.Team_BLUE] {
 		event.SetByTeam(state.Team_BLUE)
 	} else {
-		log.Printf("autoRefs undecided on team: %v. Throwing a dice.", byTeam)
-		event.SetByTeam(state.Team(s.rand.Intn(2) + 1))
+		event.SetByTeam(state.Team_UNKNOWN)
 	}
 	var events []*state.GameEvent
 	for _, p := range proposals {

internal/app/statemachine/change_gameevent.go

@@ -338,24 +338,45 @@ func (s *StateMachine) nextCommandForEvent(newState *state.State, gameEvent *sta
 		state.GameEvent_PENALTY_KICK_FAILED,
 		state.GameEvent_POSSIBLE_GOAL,
 		state.GameEvent_INVALID_GOAL:
-		return state.NewCommand(state.Command_DIRECT, gameEvent.ByTeam().Opposite())
+		return lastCommandOnUnknownTeam(
+			newState.NextCommand,
+			state.NewCommand(state.Command_DIRECT, gameEvent.ByTeam().Opposite()),
+		)
 	case state.GameEvent_DEFENDER_IN_DEFENSE_AREA:
-		return state.NewCommand(state.Command_PENALTY, gameEvent.ByTeam().Opposite())
+		return lastCommandOnUnknownTeam(
+			newState.NextCommand,
+			state.NewCommand(state.Command_PENALTY, gameEvent.ByTeam().Opposite()),
+		)
 	case state.GameEvent_GOAL:
-		return state.NewCommand(state.Command_KICKOFF, gameEvent.ByTeam().Opposite())
+		return lastCommandOnUnknownTeam(
+			newState.NextCommand,
+			state.NewCommand(state.Command_KICKOFF, gameEvent.ByTeam().Opposite()),
+		)
 	case state.GameEvent_NO_PROGRESS_IN_GAME,
 		state.GameEvent_TOO_MANY_ROBOTS:
 		return state.NewCommand(state.Command_FORCE_START, state.Team_UNKNOWN)
 	case state.GameEvent_EMERGENCY_STOP:
 		if newState.NextCommand != nil {
 			return newState.NextCommand
 		}
-		return state.NewCommand(state.Command_DIRECT, gameEvent.ByTeam().Opposite())
+		return lastCommandOnUnknownTeam(
+			newState.NextCommand,
+			state.NewCommand(state.Command_DIRECT, gameEvent.ByTeam().Opposite()),
+		)
 	default:
 		return newState.NextCommand
 	}
 }
 
+func lastCommandOnUnknownTeam(lastCommand, newCommand *state.Command) *state.Command {
+	if newCommand.ForTeam.Unknown() {
+		// no (new) next command, if the team is unknown
+		// this can happen if an autoRef majority matched by type, but not by team
+		return lastCommand
+	}
+	return newCommand
+}
+
 // incrementsFoulCounter checks if the game event increments the foul counter
 func incrementsFoulCounter(currentState *state.State, gameEvent *state.GameEvent) bool {
 	switch *gameEvent.Type {