[feature] Halt game when bot substitution is intended

Author: g3force

internal/app/controller/engine.go

@@ -86,7 +86,11 @@ func (e *Engine) UndoLastAction() {
 }
 
 func (e *Engine) Continue() {
-	if e.State.NextCommand != CommandUnknown {
+	if e.State.BotSubstitutionIntend() {
+		e.State.TeamState[TeamBlue].BotSubstitutionIntend = false
+		e.State.TeamState[TeamYellow].BotSubstitutionIntend = false
+		e.SendCommand(CommandHalt, "")
+	} else if e.State.NextCommand != CommandUnknown {
 		e.SendCommand(e.State.NextCommand, e.State.NextCommandFor)
 	}
 }
@@ -454,8 +458,8 @@ func (e *Engine) processTeamModify(m *EventModifyValue) error {
 		}
 	} else if m.CanPlaceBall != nil {
 		teamState.CanPlaceBall = *m.CanPlaceBall
-	} else if m.BotInterchangeIntend != nil {
-		teamState.BotInterchangeIntend = *m.BotInterchangeIntend
+	} else if m.BotSubstitutionIntend != nil {
+		teamState.BotSubstitutionIntend = *m.BotSubstitutionIntend
 	} else {
 		return errors.Errorf("Unknown modify: %v", m)
 	}

internal/app/controller/events.go

@@ -114,7 +114,7 @@ type EventModifyValue struct {
 	Division              *Division                     `json:"division,omitempty"`
 	AutoContinue          *bool                         `json:"autoContinue,omitempty"`
 	GameEventBehavior     *EventModifyGameEventBehavior `json:"gameEventBehavior,omitempty"`
-	BotInterchangeIntend  *bool                         `json:"botInterchangeIntend,omitempty"`
+	BotSubstitutionIntend *bool                         `json:"botSubstitutionIntend,omitempty"`
 }
 
 func (m EventModifyValue) String() string {

internal/app/controller/state.go

@@ -245,7 +245,7 @@ type TeamInfo struct {
 	CanPlaceBall          bool            `json:"canPlaceBall"`
 	MaxAllowedBots        int             `json:"maxAllowedBots"`
 	Connected             bool            `json:"connected"`
-	BotInterchangeIntend  bool            `json:"botInterchangeIntend"`
+	BotSubstitutionIntend bool            `json:"botSubstitutionIntend"`
 }
 
 type GameEventBehavior string
@@ -334,6 +334,10 @@ func (s State) GameState() GameState {
 	return ""
 }
 
+func (s State) BotSubstitutionIntend() bool {
+	return s.TeamState[TeamYellow].BotSubstitutionIntend || s.TeamState[TeamBlue].BotSubstitutionIntend
+}
+
 func newTeamInfo() (t TeamInfo) {
 	t.Name = ""
 	t.Goals = 0

src/components/team/TeamBotInterchange.vue

@@ -2,8 +2,8 @@
     <div>
         <label>Intends to interchange a bot: </label>
         <a class="btn-edit" v-on:click="edit()">
-            <font-awesome-icon icon="toggle-on" v-if="botInterchangeIntend"/>
-            <font-awesome-icon icon="toggle-off" v-if="!botInterchangeIntend"/>
+            <font-awesome-icon icon="toggle-on" v-if="botSubstitutionIntend"/>
+            <font-awesome-icon icon="toggle-off" v-if="!botSubstitutionIntend"/>
         </a>
     </div>
 </template>
@@ -19,7 +19,7 @@
                 this.$socket.sendObj({
                     'modify': {
                         'forTeam': this.teamColor,
-                        'botInterchangeIntend': !this.botInterchangeIntend
+                        'botSubstitutionIntend': !this.botSubstitutionIntend
                     }
                 })
             }
@@ -28,8 +28,8 @@
             teamState: function () {
                 return this.$store.state.refBoxState.teamState[this.teamColor]
             },
-            botInterchangeIntend() {
-                return this.teamState.botInterchangeIntend;
+            botSubstitutionIntend() {
+                return this.teamState.botSubstitutionIntend;
             },
         }
     }