[refactoring] Remove useless returning of error

Author: g3force

pkg/timer/timer.go

@@ -91,25 +91,24 @@ func (t *Timer) Stop() error {
 }
 
 // WaitTill waits until the internal timer duration is reached.
-func (t *Timer) WaitTill(duration time.Duration) error {
+func (t *Timer) WaitTill(duration time.Duration) {
 	if !t.running {
 		select {
 		case t.continueChan <- struct{}{}:
 		case <-time.After(1 * time.Second):
-			return nil
+			return
 		}
 	}
 	sleepTime := duration - t.Elapsed()
 	if sleepTime > 0 {
 		t.SleepConsumer(sleepTime)
 	}
-	return nil
+	return
 }
 
 // WaitTillNextFullSecond waits until the internal timer has reached the next full second
-func (t *Timer) WaitTillNextFullSecond() error {
+func (t *Timer) WaitTillNextFullSecond() {
 	elapsed := t.Elapsed()
 	nextDuration := elapsed.Truncate(time.Second) + time.Second
 	t.WaitTill(nextDuration)
-	return nil
 }

pkg/timer/timer_test.go

@@ -56,20 +56,14 @@ func TestTimerWaitTill(t *testing.T) {
 		t.Error(err)
 	}
 	*curTime = curTime.Add(2 * time.Second)
-	err = timer.WaitTill(5 * time.Second)
-	if err != nil {
-		t.Error(err)
-	}
+	timer.WaitTill(5 * time.Second)
 	if *sleepDuration != 3*time.Second {
 		t.Errorf("Expected a sleep duration of 3s, but was %v", *sleepDuration)
 	}
 
 	*sleepDuration = 0
 	*curTime = curTime.Add(100 * time.Millisecond)
-	err = timer.WaitTillNextFullSecond()
-	if err != nil {
-		t.Error(err)
-	}
+	timer.WaitTillNextFullSecond()
 	if *sleepDuration != 900*time.Millisecond {
 		t.Errorf("Expected a sleep duration of 900ms, but was %v", *sleepDuration)
 	}