Skip to content

Commit a3134ac

Browse files
committed
[bugfix] Remove table sorting, just use reversed event order
Sorting is not really useful for most columns and depends on continuous timestamps. There might be duplicate timestamps when using the CI mode with external time, in which case the events are not shown in the correct order.
1 parent 3281260 commit a3134ac

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

src/components/events/EventTable.vue

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
<template>
22
<b-table striped hover small
33
responsive="true"
4-
:sort-by.sync="sortBy"
5-
:sort-desc.sync="sortDesc"
64
:per-page="perPage"
75
:current-page="currentPage"
86
:items="events"
@@ -36,32 +34,24 @@
3634
},
3735
data() {
3836
return {
39-
sortBy: 'timestamp',
40-
sortDesc: true,
4137
fields: [
4238
{
4339
key: 'timestamp',
44-
sortable: true
4540
},
4641
{
4742
key: 'stageTime',
48-
sortable: true
4943
},
5044
{
5145
key: 'type',
52-
sortable: true
5346
},
5447
{
5548
key: 'name',
56-
sortable: true
5749
},
5850
{
5951
key: 'team',
60-
sortable: true
6152
},
6253
{
6354
key: 'description',
64-
sortable: true
6555
},
6656
],
6757
}

src/components/events/Events.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
},
6868
computed: {
6969
events() {
70-
return this.$store.state.gameEvents;
70+
return [...this.$store.state.gameEvents].reverse();
7171
},
7272
state() {
7373
return this.$store.state.refBoxState

0 commit comments

Comments
 (0)