Allow to disable halftime recommendations

This is useful during development, when a match is automatically simulated indefinitely.

Author: g3force

internal/app/config/config.go

@@ -61,6 +61,7 @@ type Game struct {
 	DistanceToBallInStop                  float64                    `yaml:"distance-to-ball-in-stop"`
 	AutoApproveGoals                      bool                       `yaml:"auto-approve-goals"`
 	ContinueFromHalt                      bool                       `yaml:"continue-from-halt"`
+	RecommendHalfTimes                    bool                       `yaml:"recommend-half-times"`
 	ChallengeFlags                        int32                      `yaml:"challenge-flags"`
 	EmergencyStopGracePeriod              time.Duration              `yaml:"emergency-stop-grace-period"`
 	PreparationTimeAfterHalt              time.Duration              `yaml:"preparation-time-after-halt"`
@@ -191,6 +192,8 @@ func DefaultControllerConfig() (c Controller) {
 	c.Game.BallPlacementMinRobotDistance = 0.05
 	c.Game.DistanceToBallInStop = 0.5
 	c.Game.AutoApproveGoals = false
+	c.Game.ContinueFromHalt = false
+	c.Game.RecommendHalfTimes = true
 	c.Game.ChallengeFlags = 3
 	c.Game.EmergencyStopGracePeriod = 10 * time.Second
 	c.Game.PreparationTimeAfterHalt = 10 * time.Second

internal/app/config/testdata/config.yaml

@@ -44,6 +44,7 @@ game:
   distance-to-ball-in-stop: 0.5
   auto-approve-goals: false
   continue-from-halt: false
+  recommend-half-times: true
   challenge-flags: 3
   emergency-stop-grace-period: 10s
   preparation-time-after-halt: 10s

internal/app/engine/process_continue_next_action.go

@@ -102,7 +102,9 @@ func (e *Engine) nextActions() (actions []*ContinueAction, hints []*ContinueHint
 
 	if *e.currentState.Command.Type == state.Command_STOP ||
 		*e.currentState.Command.Type == state.Command_HALT {
-		if e.currentState.StageTimeLeft.AsDuration() < 0 && *e.currentState.Stage != state.Referee_PENALTY_SHOOTOUT {
+		if (e.gameConfig.RecommendHalfTimes || e.currentState.Stage.IsPausedStage()) &&
+			e.currentState.StageTimeLeft.AsDuration() < 0 &&
+			*e.currentState.Stage != state.Referee_PENALTY_SHOOTOUT {
 			actions = append(actions, createContinueAction(
 				ContinueAction_NEXT_STAGE,
 				state.Team_UNKNOWN,