Skip to content

Commit d4f75f3

Browse files
authored
Merge pull request #148 from hbcarlos/ci
Update check-release
2 parents b6db2b3 + 1bedacf commit d4f75f3

17 files changed

+1662
-2249
lines changed

.github/workflows/build.yml

Lines changed: 31 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -2,69 +2,76 @@ name: Build
22

33
on:
44
push:
5-
branches: master
5+
branches: main
66
pull_request:
77
branches: '*'
88

99
jobs:
1010
build:
1111
runs-on: ubuntu-latest
12+
1213
steps:
1314
- name: Checkout
14-
uses: actions/checkout@v2
15+
uses: actions/checkout@v3
1516

1617
- name: Base Setup
1718
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
1819

1920
- name: Install dependencies
20-
run: python -m pip install -U check-manifest jupyterlab
21+
run: python -m pip install -U "jupyterlab>=3.0,<3.6"
2122

2223
- name: Build the extension
2324
run: |
2425
set -eux
25-
# TODO: add lint check
26-
#pushd js
27-
#jlpm
28-
#jlpm run eslint:check
29-
#popd
30-
3126
python -m pip install .
27+
28+
#jupyter server extension list
29+
#jupyter server extension list 2>&1 | grep -ie "jupyros.*OK"
30+
3231
jupyter labextension list
3332
jupyter labextension list 2>&1 | grep -ie "@robostack/jupyter-ros.*OK"
3433
python -m jupyterlab.browser_check
35-
check-manifest -v
34+
35+
- name: Package the extension
36+
run: |
37+
set -eux
3638
pip install build
37-
python -m build --sdist
38-
cp dist/*.tar.gz myextension.tar.gz
39+
python -m build
3940
pip uninstall -y "jupyros" jupyterlab
40-
rm -rf myextension
41-
- uses: actions/upload-artifact@v2
41+
42+
- name: Upload extension packages
43+
uses: actions/upload-artifact@v3
4244
with:
43-
name: myextension-sdist
44-
path: myextension.tar.gz
45+
name: extension-artifacts
46+
path: dist/jupyros*
47+
if-no-files-found: error
4548

4649
test_isolated:
4750
needs: build
4851
runs-on: ubuntu-latest
4952

5053
steps:
5154
- name: Checkout
52-
uses: actions/checkout@v2
55+
uses: actions/checkout@v3
5356
- name: Install Python
54-
uses: actions/setup-python@v2
57+
uses: actions/setup-python@v4
5558
with:
56-
python-version: '3.8'
59+
python-version: '3.9'
5760
architecture: 'x64'
58-
- uses: actions/download-artifact@v2
61+
- uses: actions/download-artifact@v3
5962
with:
60-
name: myextension-sdist
63+
name: extension-artifacts
6164
- name: Install and Test
6265
run: |
6366
set -eux
6467
# Remove NodeJS, twice to take care of system and locally installed node versions.
6568
sudo rm -rf $(which node)
6669
sudo rm -rf $(which node)
67-
pip install myextension.tar.gz
68-
pip install jupyterlab
70+
pip install "jupyterlab>=3.0,<3.6" jupyros*.whl
71+
72+
#jupyter server extension list
73+
#jupyter server extension list 2>&1 | grep -ie "jupyros.*OK"
74+
75+
jupyter labextension list
6976
jupyter labextension list 2>&1 | grep -ie "@robostack/jupyter-ros.*OK"
70-
python -m jupyterlab.browser_check --no-browser-test
77+
python -m jupyterlab.browser_check --no-chrome-test

.github/workflows/check-release.yml

Lines changed: 13 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,63 +1,31 @@
11
name: Check Release
22
on:
33
push:
4-
branches:
5-
- master
4+
branches: ["main"]
65
pull_request:
7-
branches:
8-
- master
9-
10-
permissions:
11-
contents: write
6+
branches: ["*"]
127

138
jobs:
149
check_release:
1510
runs-on: ubuntu-latest
1611
steps:
1712
- name: Checkout
18-
uses: actions/checkout@v2
19-
- name: Install Python
20-
uses: actions/setup-python@v2
21-
with:
22-
python-version: 3.9
23-
architecture: 'x64'
24-
- name: Install node
25-
uses: actions/setup-node@v2
26-
with:
27-
node-version: '14.x'
28-
29-
30-
- name: Get pip cache dir
31-
id: pip-cache
32-
run: |
33-
echo "::set-output name=dir::$(pip cache dir)"
34-
- name: Cache pip
35-
uses: actions/cache@v1
36-
with:
37-
path: ${{ steps.pip-cache.outputs.dir }}
38-
key: ${{ runner.os }}-pip-${{ hashFiles('package.json') }}
39-
restore-keys: |
40-
${{ runner.os }}-pip-
41-
- name: Cache checked links
42-
uses: actions/cache@v2
43-
with:
44-
path: ~/.cache/pytest-link-check
45-
key: ${{ runner.os }}-linkcheck-${{ hashFiles('**/.md') }}-md-links
46-
restore-keys: |
47-
${{ runner.os }}-linkcheck-
48-
- name: Upgrade packaging dependencies
49-
run: |
50-
pip install --upgrade pip setuptools wheel jupyter-packaging~=0.10 --user
13+
uses: actions/checkout@v3
14+
15+
- name: Base Setup
16+
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
17+
5118
- name: Install Dependencies
5219
run: |
53-
pip install .
20+
pip install -e .
21+
5422
- name: Check Release
55-
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v1
23+
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
5624
with:
5725
token: ${{ secrets.GITHUB_TOKEN }}
58-
26+
5927
- name: Upload Distributions
60-
uses: actions/upload-artifact@v2
28+
uses: actions/upload-artifact@v3
6129
with:
6230
name: jupyros-releaser-dist-${{ github.run_number }}
63-
path: .jupyter_releaser_checkout/dist
31+
path: .jupyter_releaser_checkout/dist

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
__pycache__
33
*.egg-info/
44

5+
jupyros/_version.py
6+
57
# JS deps
68
node_modules/
79

MANIFEST.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ graft jupyros/ros1
66
graft jupyros/ros2
77
include jupyros/_version.py
88
include jupyros/__init__.py
9+
include js/package.json
910

1011
# Extensions
1112
graf js

js/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,13 @@
4141
"devDependencies": {
4242
"@jupyterlab/builder": "^3.0.1",
4343
"npm-run-all": "^4.1.5",
44-
"rimraf": "^2.6.1",
45-
"webpack": "^5",
46-
"webpack-cli": "^4"
44+
"rimraf": "^4.1.2",
45+
"webpack": "^5.75.0",
46+
"webpack-cli": "^5.0.1"
4747
},
4848
"dependencies": {
4949
"@jupyter-widgets/base": "^2.0.1 || ^3 || ^4",
50-
"lodash": "^4.17.4",
50+
"lodash": "^4.17.21",
5151
"ros3d": "^1.0.0"
5252
},
5353
"jupyterlab": {

0 commit comments

Comments
 (0)