Skip to content

Commit 1bcbd57

Browse files
Try fixing up osx cross-compile issues with pkg-config
1 parent 17db52d commit 1bcbd57

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

vinca/main.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -338,10 +338,13 @@ def generate_output(pkg_shortname, vinca_conf, distro, version):
338338
output["requirements"]["build"] += [
339339
{"sel(build_platform != target_platform)": "pybind11"}
340340
]
341+
# pkg-config must be in build, not host
341342
if "pkg-config" in output["requirements"]["host"]:
342343
output["requirements"]["build"] += [
343344
{"sel(build_platform != target_platform)": "pkg-config"}
344345
]
346+
while "pkg-config" in output["requirements"]["host"]:
347+
output["requirements"]["host"].remove("pkg-config")
345348

346349
# fixup problems with udev (which is mapped to libusb):
347350
if "libusb" in output["requirements"]["host"]:

vinca/templates/build_catkin.sh.in

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,6 @@ fi
2525
echo "USING PYTHON_EXECUTABLE=${PYTHON_EXECUTABLE}"
2626

2727

28-
if [[ "$CONDA_BUILD_CROSS_COMPILATION" != "1" ]]; then
29-
PKG_CONFIG_EXECUTABLE=$PREFIX/bin/pkg-config
30-
else
31-
PKG_CONFIG_EXECUTABLE=$BUILD_PREFIX/bin/pkg-config
32-
fi
33-
echo "USING PKG_CONFIG_EXECUTABLE=${PKG_CONFIG_EXECUTABLE}"
34-
3528
export ROS_PYTHON_VERSION=`$PYTHON_EXECUTABLE -c "import sys; print('%i.%i' % (sys.version_info[0:2]))"`
3629
echo "Using Python $ROS_PYTHON_VERSION"
3730

@@ -57,7 +50,6 @@ cmake ${CMAKE_ARGS} .. -DCMAKE_INSTALL_PREFIX=$PREFIX \
5750
-DCMAKE_FIND_FRAMEWORK=LAST \
5851
-DBUILD_SHARED_LIBS=ON \
5952
-DPYTHON_EXECUTABLE=$PYTHON_EXECUTABLE \
60-
-DPKG_CONFIG_EXECUTABLE=$PKG_CONFIG_EXECUTABLE \
6153
-DSETUPTOOLS_DEB_LAYOUT=OFF \
6254
-DCATKIN_SKIP_TESTING=$SKIP_TESTING \
6355
-DCATKIN_BUILD_BINARY_PACKAGE=$CATKIN_BUILD_BINARY_PACKAGE \

0 commit comments

Comments
 (0)