Skip to content

Commit a68041a

Browse files
authored
[drake_bazel_external_legacy] Pin to Drake v1.44 (#427)
Note the imminent removal of this example. Disable CI (no longer makes sense to test Drake's master branch). Also fix string literal warning in file_sync_test.
1 parent c1a7255 commit a68041a

File tree

8 files changed

+9
-65
lines changed

8 files changed

+9
-65
lines changed

Jenkinsfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ if (env.BRANCH_NAME == 'main') {
2626

2727
properties(props)
2828

29-
def examples = ['drake_bazel_external', 'drake_bazel_external_legacy', 'drake_cmake_external']
29+
def examples = ['drake_bazel_external', 'drake_cmake_external']
3030
def jobs = [:]
3131

3232
for (example in examples) {

drake_bazel_external_legacy/.github/ci_build_test

Lines changed: 0 additions & 22 deletions
This file was deleted.

drake_bazel_external_legacy/.github/setup

Lines changed: 0 additions & 10 deletions
This file was deleted.

drake_bazel_external_legacy/.github/ubuntu_setup

Lines changed: 0 additions & 22 deletions
This file was deleted.

drake_bazel_external_legacy/README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33
This pulls in Drake and builds it from source via Bazel's WORKSPACE mechanism,
44
which is deprecated as of Bazel 8 and will be removed in Bazel 9. Therefore,
55
we do not recommend using this example for new projects; instead, refer to
6-
the `drake_bazel_external` example. The legacy example primarily serves
7-
as a regression test for the deprecated behavior, and therefore uses Drake's
8-
minimum supported Bazel version.
6+
the `drake_bazel_external` example.
7+
8+
The WORKSPACE mechanism is only supported for Drake v1.44.0 and earlier. This
9+
example will be deleted after the next version of Drake (v1.45.0) is released.
910

1011
For an introduction to Bazel, refer to
1112
[Getting Started with Bazel](https://bazel.build/start).

drake_bazel_external_legacy/WORKSPACE

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
workspace(name = "drake_external_examples")
44

5-
DRAKE_COMMIT = "master"
6-
DRAKE_CHECKSUM = ""
5+
DRAKE_COMMIT = "v1.44.0"
6+
DRAKE_CHECKSUM = "6df6dc50f2df53ebb526b01995e1f604ee5f8a546dcda23428449bcfd1fb3e6b"
77

88
# Or choose a specific revision of Drake to use.
99
# DRAKE_COMMIT = "be4f658487f739ba04ec079de46f9459b719636d"

drake_bazel_external_legacy/setup/install_prereqs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
set -euxo pipefail
66

7-
drake_commit_hash='master'
7+
drake_commit_hash='v1.44.0'
88

99
while [ "${1:-}" != "" ]; do
1010
case "$1" in

private/test/file_sync_test.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@
6060
".bazelignore",
6161
".bazelproject",
6262
".clang-format",
63-
".github/setup",
64-
".github/ubuntu_setup",
6563
"BUILD.bazel",
6664
"CPPLINT.cfg",
6765
"LICENSE",
@@ -77,7 +75,6 @@
7775
"apps/simple_adder_test.cc",
7876
"apps/simple_continuous_time_system.cc",
7977
"apps/simple_logging_example.py",
80-
"setup/install_prereqs",
8178
]
8279
]) + tuple([
8380
(
@@ -221,7 +218,7 @@ def check_sep(paths, sep):
221218

222219
root_dispatch = content[root_ci_path].split(seps["dispatch"])[1].split(seps["conc"])[0]
223220
subdir_dispatch = content[subdir_ci_path].split(seps["dispatch"])[1].split(seps["conc"])[0]
224-
subdir_dispatch = re.sub("[^\S\r\n]{6}", "", subdir_dispatch) # remove leading indendation
221+
subdir_dispatch = re.sub(r"[^\S\r\n]{6}", "", subdir_dispatch) # Remove leading indentation.
225222

226223
# Check that the root workflow defines no extra options
227224
# beyond what is configured here.

0 commit comments

Comments
 (0)