Remove actionlib related tests

This patch remove actionlib related tests, as the actionlib feature has
been deprecated, see https://github.com/RobotWebTools/rclnodejs#experimental---deprecated

Meanwhile, the patch fixes some cpp files used for testing interacting
with rclcpp.

Fix #None

Author: Minggang Wang

.circleci/config.yml

@@ -20,7 +20,8 @@ jobs:
     - run: brew update
     - run: brew uninstall python
     - run: brew install python
-    - run: brew install wget cmake cppcheck tinyxml tinyxml2 eigen pcre poco
+    - run: brew install wget cmake cppcheck tinyxml tinyxml2 eigen pcre
+    - run: brew install https://raw.githubusercontent.com/alebcay/homebrew-core/419873be053a08233d9fd3952f2615c139902434/Formula/poco.rb
     - run: brew install openssl
     - run: brew install asio console_bridge
     - run: python3 -m pip install catkin_pkg empy git+https://github.com/lark-parser/[email protected] pyparsing pyyaml setuptools argcomplete colcon-common-extensions numpy

appveyor.yml

@@ -6,7 +6,7 @@ branches:
     - develop
     - actionlib
 
-image: Visual Studio 2017
+image: Visual Studio 2019
 
 environment:
   nodejs_version: "10"
@@ -50,6 +50,6 @@ build_script:
   - npm run lint
 
 test_script:
-  - cmd: call "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\Tools\VsDevCmd.bat"
+  - cmd: call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\Tools\VsDevCmd.bat"
   - "SET PATH=%PYTHON3%;%PYTHON3%\\bin;%PYTHON3%\\Scripts;C:\\Program Files\\CMake\\bin;%PATH%"
   - npm test

package.json

@@ -30,7 +30,8 @@
   },
   "devDependencies": {
     "eslint": "^5.14.1",
-    "mocha": "^6.0.1"
+    "mocha": "^6.0.1",
+    "tree-kill": "^1.2.1"
   },
   "dependencies": {
     "bindings": "^1.2.1",

scripts/compile_tests.js

@@ -106,26 +106,4 @@ if (!fs.existsSync(publisherPath) && !fs.existsSync(subscriptionPath) &&
 } else {
   copyAll([publisherPath, subscriptionPath, , listenerPath, clientPath], testCppDir);
 }
-
-let actionPath = path.join(rootDir, 'test', 'ros1_actions');
-process.env.AMENT_PREFIX_PATH = process.env.AMENT_PREFIX_PATH + path.delimiter + actionPath;
-
-const generator = require('../rosidl_gen/index.js');
-
-generator.generateAll(true).then(() => {
-  console.log('Generation is done.');
-
-  let actionBuildProcess = child.spawn('colcon', ['build', '--base-paths', actionPath]);
-  actionBuildProcess.on('close', (code) => {
-    copyPkgToRos2('ros1_actions');
-  });
-  actionBuildProcess.stdout.on('data', (data) => {
-    console.log(`${data}`);
-  });
-  actionBuildProcess.stderr.on('data', (data) => {
-    console.log(`${data}`);
-  });
-}).catch((e) => {
-  console.log(`Caught error: ${e}`);
-});
 /* eslint-enable */

test/cpp/add_two_ints_client.cpp

@@ -57,7 +57,7 @@ int main(int argc, char ** argv)
 {
   rclcpp::init(argc, argv);
 
-  auto node = rclcpp::Node::make_shared("add_two_ints_client");
+  auto node = rclcpp::Node::make_shared("add_two_ints_client", rclcpp::NodeOptions());
 
   if (rcutils_cli_option_exist(argv, argv + argc, "-h")) {
     print_usage();

test/cpp/listener.cpp

@@ -42,7 +42,7 @@ void chatterCallback(const std_msgs::msg::String::SharedPtr msg)
 int main(int argc, char * argv[])
 {
   rclcpp::init(argc, argv);
-  auto node = rclcpp::Node::make_shared("listener");
+  auto node = rclcpp::Node::make_shared("listener", rclcpp::NodeOptions());
 
   if (rcutils_cli_option_exist(argv, argv + argc, "-h")) {
     print_usage();

test/cpp/publisher_msg.cpp

@@ -73,7 +73,7 @@ int main(int argc, char* argv[]) {
 
   rclcpp::init(argc, argv);
 
-  auto node = rclcpp::Node::make_shared("cpp_publisher");
+  auto node = rclcpp::Node::make_shared("cpp_publisher", rclcpp::NodeOptions());
 
   if (rcutils_cli_option_exist(argv, argv + argc, "-h")) {
     print_usage();

test/cpp/subscription_msg.cpp

@@ -135,7 +135,7 @@ void jointstateCallback(sensor_msgs::msg::JointState::SharedPtr msg) {
 int main(int argc, char * argv[])
 {
   rclcpp::init(argc, argv);
-  auto node = rclcpp::Node::make_shared("cpp_subscription");
+  auto node = rclcpp::Node::make_shared("cpp_subscription", rclcpp::NodeOptions());
 
   // Bool
   bool_pub = node->create_publisher<std_msgs::msg::Bool>(