Skip to content

Commit 1538329

Browse files
committed
Address comments
1 parent 20f3ebc commit 1538329

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

.github/workflows/windows-build-and-test.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,21 +54,18 @@ jobs:
5454
wget --quiet https://ci.ros2.org/view/packaging/job/packaging_windows/lastSuccessfulBuild/artifact/ws/ros2-package-windows-AMD64.zip -O rolling.zip
5555
7z x rolling.zip -y -o/c/dev/rolling
5656
57-
- name: Prebuild - Setup VS Dev Environment
58-
uses: seanmiddleditch/gha-setup-vsdevenv@v4
59-
6057
- uses: actions/checkout@v4
6158

6259
- name: Build rclnodejs
6360
shell: cmd
6461
run: |
6562
call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat"
66-
cmd /c "set RMW_IMPLEMENTATION=rmw_fastrtps_cpp&&npm i"
63+
npm i
6764
6865
# On the windows/foxy combination the Eclipse CycloneDDS RMW implementation is used to workaround
6966
# an error when loading the default fastrtps ddl
7067
- name: Test rclnodejs
7168
shell: cmd
7269
run: |
7370
call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat"
74-
cmd /c "set RMW_IMPLEMENTATION=rmw_fastrtps_cpp&&npm test"
71+
cmd /c "set RMW_IMPLEMENTATION=rmw_fastrtps_cpp & &npm test"

0 commit comments

Comments
 (0)