Re-enable cpplint & eslint for Linux platform actions (#1057)

This patch migrates `ESLint` configuration, `.eslintrc.yml` to [the new flat config format](https://eslint.org/docs/latest/use/configure/migration-guide) by creating `eslint.config.mjs`, meanwhile, re-enables [cpplint](https://github.com/cpplint/cpplint) for Linux platform actions, including:

1. Config `eslint` using recommended configs for `*.js` files in`eslint.config.mjs`.
2. Config `eslint-plugin-prettier` using recommended configs for `*.js` files in `eslint.config.mjs`.
3. Config `@typescript-eslint/eslint-plugin` using recommended configs for `*.d.ts` files in `eslint.config.mjs`.
4. Re-enable [`cpplint.py`](https://github.com/cpplint/cpplint/blob/develop/cpplint.py) for `*.{hpp,cpp}` files.
5. Fix errors/warnings reported by linters above.
6. Add `npm run lint` as addition step for actions, `.github/workflows/linux-build-and-test-compatibility.yml` and `.github/workflows/linux-build-and-test.yml`.
7. Remove original `.eslintrc.yml`.

Fix: #1056

Author: minggangw

.eslintrc.yml

@@ -35,4 +35,5 @@ jobs:
       run: |
         source /opt/ros/${{ matrix.ros_distribution }}/setup.bash
         npm i
+        npm run lint
         npm test

.github/workflows/linux-build-and-test-compatibility.yml

@@ -50,4 +50,5 @@ jobs:
       run: |
         source /opt/ros/${{ needs.identify-ros-distro.outputs.distro }}/setup.bash
         npm i
+        npm run lint
         npm test

.github/workflows/linux-build-and-test.yml

@@ -0,0 +1,65 @@
+import typescriptEslint from "@typescript-eslint/eslint-plugin";
+import prettier from "eslint-plugin-prettier";
+import globals from "globals";
+import tsParser from "@typescript-eslint/parser";
+import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended';
+import js from "@eslint/js";
+
+export default [
+    {
+        ignores: [
+            "eslint.config.mjs",
+            "types/interfaces.d.ts",
+            "test/types/index.test-d.ts",
+            "**/generated/",
+            "**/scripts/",
+            "**/benchmark/",
+            "**/docs/",
+            "**/electron_demo/",
+        ],
+    },
+    {
+        ...js.configs.recommended,
+        files: ["lib/**/*.js", "index.js"],
+    },
+    {
+        rules: {
+            'no-dupe-class-members': 'off',
+        },
+    },
+    {
+        plugins: {
+            "@typescript-eslint": typescriptEslint,
+        },
+        languageOptions: {
+            globals: {
+                ...globals.node,
+            },
+            parser: tsParser,
+            ecmaVersion: "latest",
+            sourceType: "module",
+        },
+        files: ['types/*.d.ts'],
+        rules: {
+            ...typescriptEslint.configs.recommended.rules,
+            "@typescript-eslint/no-explicit-any": "off",
+        },
+    },
+    {
+        plugins: {
+            prettier,
+        },
+        languageOptions: {
+            globals: {
+                ...globals.node,
+            },
+            ecmaVersion: "latest",
+            sourceType: "commonjs",
+        },
+        files: ["lib/**/*.js", "rosidl_parser/**/*.js", "rosidl_gen/**/*.js",
+            "rostsd_gen/**/*.js", "test/**/*.js", "example/**/*.js", "index.js"],
+        rules: {
+            ...eslintPluginPrettierRecommended.rules,
+        },
+    }
+];

eslint.config.mjs

@@ -14,8 +14,6 @@
 
 'use strict';
 
-/* eslint-disable camelcase */
-
 const rclnodejs = require('../index.js');
 
 async function main() {

example/publisher-content-filter-example.js

@@ -14,8 +14,6 @@
 
 'use strict';
 
-/* eslint-disable camelcase */
-
 const rclnodejs = require('../index.js');
 
 rclnodejs

example/publisher-message-example.js

@@ -14,8 +14,6 @@
 
 'use strict';
 
-/* eslint-disable camelcase */
-
 const rclnodejs = require('../index.js');
 
 rclnodejs

example/publisher-multiarray-example.js

@@ -14,8 +14,6 @@
 
 'use strict';
 
-/* eslint-disable camelcase */
-
 const rclnodejs = require('../index.js');
 
 rclnodejs

example/publisher-raw-message.js

@@ -36,7 +36,7 @@ rclnodejs
         const weightStride = dim[1].stride;
         const channel = dim[2].size;
         const channelStride = dim[2].stride;
-        // eslint-disable-next-line
+
         const offset = multiArray.layout.data_offset;
 
         for (let i = 0; i < height; i++) {

example/subscription-multiarray-example.js

@@ -14,8 +14,6 @@
 
 'use strict';
 
-/* eslint-disable camelcase */
-
 const rclnodejs = require('../index.js');
 
 rclnodejs.init().then(() => {