Skip to content

Commit 1e20d13

Browse files
committed
Address comments
1 parent dce80c6 commit 1e20d13

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

lib/node.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ class Node extends rclnodejs.ShadowNode {
6767
namespace = '',
6868
context = Context.defaultContext(),
6969
options = NodeOptions.defaultOptions,
70-
args,
71-
useGlobalArguments
70+
args = [],
71+
useGlobalArguments = true
7272
) {
7373
super();
7474

src/rcl_node_bindings.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,13 +185,14 @@ Napi::Value CreateNode(const Napi::CallbackInfo& info) {
185185
Napi::Array jsArgv = info[3].As<Napi::Array>();
186186
size_t argc = jsArgv.Length();
187187
char** argv = AbstractArgsFromNapiArray(jsArgv);
188+
RCPPUTILS_SCOPE_EXIT({ FreeArgs(argv, argc); });
189+
188190
rcl_arguments_t arguments = rcl_get_zero_initialized_arguments();
189191
rcl_ret_t ret =
190192
rcl_parse_arguments(argc, argv, rcl_get_default_allocator(), &arguments);
191193
if ((ret != RCL_RET_OK) || HasUnparsedROSArgs(arguments)) {
192194
Napi::Error::New(env, "failed to parse arguments")
193195
.ThrowAsJavaScriptException();
194-
FreeArgs(argv, argc);
195196
return env.Undefined();
196197
}
197198

0 commit comments

Comments
 (0)