Fix compiling error when using Node.js v10.12.0

Minggang Wang · Minggang Wang · commit 1e3657b28aa6 · 2020-07-21T16:02:58.000+08:00
This patch changes to use Nan methods instead of calling v8 object directly, which cause imcompatibility between different Node.js versions. Fix #677
diff --git a/src/rcl_bindings.cpp b/src/rcl_bindings.cpp
@@ -1219,8 +1219,7 @@ std::unique_ptr<rmw_qos_profile_t> GetQosProfileFromObject(
   qos_profile->durability = static_cast<rmw_qos_durability_policy_t>(
       Nan::To<uint32_t>(durability).FromJust());
   qos_profile->avoid_ros_namespace_conventions =
-      avoid_ros_namespace_conventions->BooleanValue(
-          currentContent->GetIsolate());
+      Nan::To<bool>(avoid_ros_namespace_conventions).FromJust();
 
   return qos_profile;
 }

Original file line number	Diff line number	Diff line change
`@@ -1219,8 +1219,7 @@ std::unique_ptr<rmw_qos_profile_t> GetQosProfileFromObject(`
`1219`	`1219`	`qos_profile->durability = static_cast<rmw_qos_durability_policy_t>(`
`1220`	`1220`	`Nan::To<uint32_t>(durability).FromJust());`
`1221`	`1221`	`qos_profile->avoid_ros_namespace_conventions =`
`1222`		`- avoid_ros_namespace_conventions->BooleanValue(`
`1223`		`- currentContent->GetIsolate());`
	`1222`	`+ Nan::To<bool>(avoid_ros_namespace_conventions).FromJust();`
`1224`	`1223`
`1225`	`1224`	`return qos_profile;`
`1226`	`1225`	`}`