Skip to content

Commit 2332423

Browse files
committed
Adapt C++20 (#1020)
Currently, we adapt C++17 to compile the C++ addon, but nodejs 23.X needs C++20 to develop addon, this patch: 1. Adapt C++20 for Windows & Linux platforms, keeping macOS as C++17. 2. Add checking for nodejs 23.X into actions for Linux platform. Fix: #1019
1 parent 6bdaa98 commit 2332423

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/linux-build-and-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
strategy:
3131
fail-fast: false
3232
matrix:
33-
node-version: [20.X, 22.X]
33+
node-version: [20.X, 22.X, 23.X]
3434
steps:
3535
- name: Setup Node.js ${{ matrix.node-version }}
3636
uses: actions/setup-node@v4

binding.gyp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
'OS_LINUX'
6161
],
6262
'cflags_cc': [
63-
'-std=c++17'
63+
'-std=c++20'
6464
],
6565
'include_dirs':
6666
[
@@ -104,7 +104,7 @@
104104
'OS_WINDOWS'
105105
],
106106
'cflags_cc': [
107-
'-std=c++17'
107+
'-std=c++20'
108108
],
109109
'include_dirs': [
110110
'./src/third_party/dlfcn-win32/',

0 commit comments

Comments
 (0)