Merge pull request #145 from minggangw/xcode-settings

Minggang Wang · web-flow · commit 2c73037824af · 2017-10-19T16:40:11.000+08:00
Change the xcode settings to wipe out the warnings.
diff --git a/binding.gyp b/binding.gyp
@@ -94,11 +94,10 @@
               '-L<(ROS2_INSTALL_PATH)/lib'
             ],
             'xcode_settings': {
-              'OTHER_CPLUSPLUSFLAGS': [
-                '-std=c++14',
-                '-stdlib=libc++'
-              ],
               'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
+              'CLANG_CXX_LIBRARY': 'libc++',
+              'MACOS_DEPLOYMENT_TARGET': '10.12',
+              'CLANG_CXX_LANGUAGE_STANDARD': 'c++14'
             }
           }
         ]

Original file line number	Diff line number	Diff line change
`@@ -94,11 +94,10 @@`
`94`	`94`	`'-L<(ROS2_INSTALL_PATH)/lib'`
`95`	`95`	`],`
`96`	`96`	`'xcode_settings': {`
`97`		`- 'OTHER_CPLUSPLUSFLAGS': [`
`98`		`- '-std=c++14',`
`99`		`- '-stdlib=libc++'`
`100`		`- ],`
`101`	`97`	`'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',`
	`98`	`+ 'CLANG_CXX_LIBRARY': 'libc++',`
	`99`	`+ 'MACOS_DEPLOYMENT_TARGET': '10.12',`
	`100`	`+ 'CLANG_CXX_LANGUAGE_STANDARD': 'c++14'`
`102`	`101`	`}`
`103`	`102`	`}`
`104`	`103`	`]`