Skip to content

Commit 2d7bbc0

Browse files
committed
Address comments
1 parent 71832ea commit 2d7bbc0

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

ts_demo/actions/src/client.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ class FibonacciActionClient {
5454

5555
try {
5656
// Send the goal with feedback callback
57-
console.log(goal);
5857
const goalHandle = await this.actionClient.sendGoal(
5958
goal,
6059
(feedback: any) => this.feedbackCallback(feedback)

ts_demo/actions/src/server.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -114,14 +114,10 @@ class FibonacciActionServer {
114114
*
115115
* Note: According to the type definition, this should receive ActionGoal<T>,
116116
* but the actual implementation may pass different types. Using 'any' to handle
117-
* this inconsistency and support both ActionGoal<T> and ServerGoalHandle<T>.
117+
* this inconsistency and support ActionGoal<T>.
118118
*/
119-
goalCallback(goalHandle: any): rclnodejs.GoalResponse {
120-
// Handle both ActionGoal<T> (with direct .order) and ServerGoalHandle<T> (with .request.order)
121-
const order =
122-
goalHandle.order !== undefined
123-
? goalHandle.order
124-
: goalHandle.request?.order;
119+
goalCallback(goal: any): rclnodejs.GoalResponse {
120+
const order = goal.order;
125121

126122
this.node
127123
.getLogger()

0 commit comments

Comments
 (0)