Address comments

minggangw · minggangw · commit 30415e1a7b71 · 2025-05-19T17:38:35.000+08:00
diff --git a/src/rcl_publisher_bindings.cpp b/src/rcl_publisher_bindings.cpp
@@ -143,7 +143,7 @@ Napi::Value WaitForAllAcked(const Napi::CallbackInfo& info) {
   }
   Napi::Error::New(env, "Failed to wait for all acknowledgements")
       .ThrowAsJavaScriptException();
-  throw env.Undefined();
+  return env.Undefined();
 }
 
 Napi::Object InitPublisherBindings(Napi::Env env, Napi::Object exports) {

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ Napi::Value WaitForAllAcked(const Napi::CallbackInfo& info) {`
`143`	`143`	`}`
`144`	`144`	`Napi::Error::New(env, "Failed to wait for all acknowledgements")`
`145`	`145`	`.ThrowAsJavaScriptException();`
`146`		`- throw env.Undefined();`
	`146`	`+ return env.Undefined();`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`Napi::Object InitPublisherBindings(Napi::Env env, Napi::Object exports) {`