Skip to content

Commit 30c693d

Browse files
committed
Address comments
1 parent 75d7a87 commit 30c693d

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/rcl_action_client_bindings.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ Napi::Value GetNumEntities(const Napi::CallbackInfo& info) {
211211
std::string error_text{
212212
"Failed to get number of entities for 'rcl_action_client_t'"};
213213
Napi::Error::New(env, error_text).ThrowAsJavaScriptException();
214-
throw;
214+
return env.Undefined();
215215
}
216216
Napi::Object entities = Napi::Object::New(env);
217217
entities.Set("subscriptionsNumber",
@@ -248,8 +248,6 @@ Napi::Object InitActionClientBindings(Napi::Env env, Napi::Object exports) {
248248
Napi::Function::New(env, ActionServerIsAvailable));
249249
exports.Set("actionSendGoalRequest",
250250
Napi::Function::New(env, ActionSendGoalRequest));
251-
exports.Set("actionTakeCancelRequest",
252-
Napi::Function::New(env, ActionTakeCancelRequest));
253251
exports.Set("actionSendResultRequest",
254252
Napi::Function::New(env, ActionSendResultRequest));
255253
exports.Set("actionTakeFeedback",

0 commit comments

Comments
 (0)