Correct parameter type

Author: minggangw

lib/parameter.js

@@ -34,6 +34,7 @@ const rclnodejs = require('bindings')('rclnodejs');
 const DEFAULT_NUMERIC_RANGE_TOLERANCE = 1e-6;
 
 const PARAMETER_SEPARATOR = '.';
+const PARAMETER_BYTE = 10;
 
 /**
  * Enum for ParameterType
@@ -61,8 +62,6 @@ const ParameterType = {
   PARAMETER_DOUBLE_ARRAY: 8,
   /** @member {number} */
   PARAMETER_STRING_ARRAY: 9,
-  /** @member {number} */
-  PARAMETER_BYTE: 10,
 };
 
 /**
@@ -676,8 +675,6 @@ class IntegerRange extends Range {
    */
   isValidType(parameterType) {
     const result =
-      parameterType === ParameterType.PARAMETER_BYTE ||
-      parameterType === ParameterType.PARAMETER_BYTE_ARRAY ||
       parameterType === ParameterType.PARAMETER_INTEGER ||
       parameterType === ParameterType.PARAMETER_INTEGER_ARRAY;
     return result;
@@ -770,7 +767,7 @@ function validValue(value, type) {
       result = typeof value === 'string';
       break;
     case ParameterType.PARAMETER_DOUBLE:
-    case ParameterType.PARAMETER_BYTE:
+    case PARAMETER_BYTE:
       result = typeof value === 'number';
       break;
     case ParameterType.PARAMETER_INTEGER:
@@ -798,7 +795,7 @@ function _validArray(values, type) {
   if (type === ParameterType.PARAMETER_BOOL_ARRAY) {
     arrayElementType = ParameterType.PARAMETER_BOOL;
   } else if (type === ParameterType.PARAMETER_BYTE_ARRAY) {
-    arrayElementType = ParameterType.PARAMETER_BYTE;
+    arrayElementType = PARAMETER_BYTE;
   }
   if (type === ParameterType.PARAMETER_INTEGER_ARRAY) {
     arrayElementType = ParameterType.PARAMETER_INTEGER;

types/parameter.d.ts

@@ -45,7 +45,7 @@ declare module 'rclnodejs' {
      *
      * @param name - The parameter name, must be a valid name.
      * @param type - The type identifier.
-     * @param {value - The parameter value.
+     * @param value - The parameter value.
      */
     constructor(name: string, type: ParameterType, value?: any);
 
@@ -265,15 +265,11 @@ declare module 'rclnodejs' {
     /**
      * Create a new instance.
      * @constructor
-     * @param {bigint|number} fromValue - The lowest inclusive value in range
-     * @param {bigint|number} toValue - The highest inclusive value in range
-     * @param {bigint|number} step - The internal unit size.
+     * @param {bigint} fromValue - The lowest inclusive value in range
+     * @param {bigint} toValue - The highest inclusive value in range
+     * @param {bigint} step - The internal unit size.
      */
-    constructor(
-      from: bigint | number,
-      to: bigint | number,
-      step?: bigint | number
-    );
+    constructor(from: bigint, to: bigint, step?: bigint);
 
     /**
      * Determine if a ParameterType is compatible.