Skip to content

Commit 3991d0e

Browse files
committed
Address comments
1 parent caabb69 commit 3991d0e

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

lib/node.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -862,8 +862,8 @@ class Node extends rclnodejs.ShadowNode {
862862
throw new TypeError('Invalid argument');
863863
}
864864
if (publisher.events) {
865-
publisher.events.forEach((handler) => {
866-
this._destroyEntity(handler, this._events);
865+
publisher.events.forEach((event) => {
866+
this._destroyEntity(event, this._events);
867867
});
868868
publisher.events = [];
869869
}
@@ -880,8 +880,8 @@ class Node extends rclnodejs.ShadowNode {
880880
throw new TypeError('Invalid argument');
881881
}
882882
if (subscription.events) {
883-
subscription.events.forEach((handler) => {
884-
this._destroyEntity(handler, this._events);
883+
subscription.events.forEach((event) => {
884+
this._destroyEntity(event, this._events);
885885
});
886886
subscription.events = [];
887887
}

lib/publisher.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,6 @@ class Publisher extends Entity {
116116
* @returns {Array} The array of event handlers for this publisher.
117117
*/
118118
get events() {
119-
if (!this._events) {
120-
throw new Error('Event handlers are not set for this publisher.');
121-
}
122119
return this._events;
123120
}
124121

@@ -127,9 +124,6 @@ class Publisher extends Entity {
127124
* @param {Array} events - The array of event handlers to be set for this publisher.
128125
*/
129126
set events(events) {
130-
if (this._events) {
131-
throw new Error('Event handlers are already set for this publisher.');
132-
}
133127
this._events = events;
134128
}
135129
}

0 commit comments

Comments
 (0)