Skip to content

Commit 5055879

Browse files
committed
Address comments
1 parent 67f3b8e commit 5055879

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

.github/workflows/windows-build-and-test.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,21 +45,18 @@ jobs:
4545
wget --quiet https://ci.ros2.org/view/packaging/job/packaging_windows/lastSuccessfulBuild/artifact/ws/ros2-package-windows-AMD64.zip -O rolling.zip
4646
7z x rolling.zip -y -o/c/dev/rolling
4747
48-
- name: Prebuild - Setup VS Dev Environment
49-
uses: seanmiddleditch/gha-setup-vsdevenv@v4
50-
5148
- uses: actions/checkout@v4
5249

5350
- name: Build rclnodejs
5451
shell: cmd
5552
run: |
5653
call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat"
57-
cmd /c "set RMW_IMPLEMENTATION=rmw_fastrtps_cpp&&npm i"
54+
npm i
5855
5956
# On the windows/foxy combination the Eclipse CycloneDDS RMW implementation is used to workaround
6057
# an error when loading the default fastrtps ddl
6158
- name: Test rclnodejs
6259
shell: cmd
6360
run: |
6461
call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat"
65-
cmd /c "set RMW_IMPLEMENTATION=rmw_fastrtps_cpp&&npm test"
62+
cmd /c "set RMW_IMPLEMENTATION=rmw_fastrtps_cpp & &npm test"

0 commit comments

Comments
 (0)