Skip to content

Commit 597b7f9

Browse files
wayneparrottMinggang Wang
authored andcommitted
Fixes GCC 8.X compiler warnings.
Changes: executor.cpp - reorder member initialization in constructor binding.gyp - add compiler flags -Wextra -Wno-cast-function-type package.json - upgraded nan to 2.14.2
1 parent d0ae86b commit 597b7f9

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

binding.gyp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
'-fstack-protector-strong',
3636
'-fPIE -fPIC',
3737
'-O2 -D_FORTIFY_SOURCE=2',
38-
'-Wformat -Wformat-security'
38+
'-Wformat -Wformat-security -Wextra -Wno-cast-function-type'
3939
],
4040
'cflags_cc!': [
4141
'-fno-exceptions'

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
"is-close": "^1.3.3",
6565
"mkdirp": "^1.0.4",
6666
"mz": "^2.7.0",
67-
"nan": "^2.14.1",
67+
"nan": "^2.14.2",
6868
"ref-napi": "^3.0.0",
6969
"ref-array-di": "^1.2.2",
7070
"ref-struct-di": "^1.1.1",

src/executor.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ struct RclResult {
4343

4444
Executor::Executor(HandleManager* handle_manager, Delegate* delegate)
4545
: async_(nullptr),
46+
main_thread_(uv_thread_self()),
4647
handle_manager_(handle_manager),
4748
delegate_(delegate),
48-
context_(nullptr),
49-
main_thread_(uv_thread_self()) {
49+
context_(nullptr) {
5050
running_.store(false);
5151
}
5252

0 commit comments

Comments
 (0)