Merge pull request #254 from qiuzhong/tc-4pr251

Complete test cases for missing APIs in PR251

Author: Minggang Wang

test/test-existance.js

@@ -22,6 +22,18 @@ const assertThrowsError = assertUtils.assertThrowsError;
 
 describe('rclnodejs module existance testing', function() {
   describe('rclnodejs module members', function() {
+    it('QoS member should exist', function() {
+      assertMember('QoS', rclnodejs, rclnodejs.QoS, 'function');
+    });
+
+    it('validator member should exist', function() {
+      assertMember('validator', rclnodejs, rclnodejs.validator, 'object');
+    });
+
+    it('createMessageObject method should exist', function() {
+      assertMember('createMessageObject', rclnodejs, rclnodejs.createMessageObject, 'function');
+    });
+
     it('createNode method should exist', function() {
       assertMember('createNode', rclnodejs, rclnodejs.createNode, 'function');
     });
@@ -142,29 +154,65 @@ describe('rclnodejs class existance testing', function() {
 
     it('destroyTimer method should exist', function() {
       assertMember('destroyTimer', node, node.destroyTimer, 'function');
-    });    
+    });
+
+    it('name method should exist', function() {
+      assertMember('name', node, node.name, 'function');
+    });
+
+    it('namespace method should exist', function() {
+      assertMember('namespace', node, node.namespace, 'function');
+    });        
   });
 
-  describe('Publisher class', function() {
-    var node, RclString, publisher;
+  describe('Publisher & Subscription class', function() {
+    var node, RclString, publisher, subscription;
 
     before(function() {
       node = rclnodejs.createNode('Publisher');
       RclString = 'std_msgs/msg/String';
       publisher = node.createPublisher(RclString, 'chatter');
+      subscription = node.createSubscription(RclString, 'chatter', () => {});
     });
 
     after(function() {
       node.destroy();
     });
 
-    it('topic property should exist', function() {
+    it('topic property of a publisher should exist', function() {
       assertMember('topic', publisher, publisher.topic, 'string');
     });
 
-    it('publish method should exist', function() {
+    it('publish method of a publisher should exist', function() {
       assertMember('publish', publisher, publisher.publish, 'function');
     });
+
+    it('topic member of a subscription should exist', function() {
+      assertMember('topic', subscription, subscription.topic, 'string');
+    });    
+  });
+
+  describe('Client & Service class', function() {
+    var node, AddTwoInts, client, service;
+
+    before(function() {
+      node = rclnodejs.createNode('Client');
+      AddTwoInts = 'example_interfaces/srv/AddTwoInts';
+      client = node.createClient(AddTwoInts, 'add_two_ints', (req, res) => {});
+      service = node.createService(AddTwoInts, 'add_two_ints', (req) => {});
+    });
+
+    after(function() {
+      node.destroy();
+    });
+
+    it('serviceName member of a client should exist', function() {
+      assertMember('serviceName', client, client.serviceName, 'string');
+    });
+
+    it('serviceName member of a service should exist', function() {
+      assertMember('serviceName', service, service.serviceName, 'string');
+    });    
   });
 
   describe('Timer class', function() {
@@ -200,7 +248,7 @@ describe('rclnodejs class existance testing', function() {
     it('reset method should exist', function() {
       assertMember('reset', timer, timer.reset, 'function');
     });
-    
+
     it('timeSinceLastCall method should exist', function() {
       assertMember('timeSinceLastCall', timer, timer.timeSinceLastCall, 'function');
     });    

test/test-node.js

@@ -305,3 +305,46 @@ describe('rcl node methods testing', function() {
     });
   });
 });
+
+describe('topic & serviceName getter/setter', function() {
+  const RclString = 'std_msgs/msg/String';
+  const AddTwoInts = 'example_interfaces/srv/AddTwoInts';
+
+  this.timeout(60 * 1000);
+
+  before(function() {
+    return rclnodejs.init();
+  });
+
+  after(function() {
+    rclnodejs.shutdown();
+  });
+
+  it('publisher: topic property getter', function() {
+    var node = rclnodejs.createNode('publisher', '/topic_getter');
+    var publisher = node.createPublisher(RclString, 'chatter');
+    assert.deepStrictEqual(publisher.topic, 'chatter');
+    node.destroy();
+  });
+
+  it('subscription: topic property getter', function() {
+    var node = rclnodejs.createNode('subscription', '/topic_getter');
+    var subscription = node.createSubscription(RclString, 'chatter', (msg) => {});
+    assert.deepStrictEqual(subscription.topic, 'chatter');
+    node.destroy();
+  });
+
+  it('client: serviceName property getter', function() {
+    var node = rclnodejs.createNode('client', '/servicename_getter');
+    var client = node.createClient(AddTwoInts, 'add_two_ints', (req, res) => {});
+    assert.deepStrictEqual(client.serviceName, 'add_two_ints');
+    node.destroy();
+  });
+
+  it('service: topic property getter', function() {
+    var node = rclnodejs.createNode('service', '/servicename_getter');
+    var service = node.createService(AddTwoInts, 'add_two_ints', (req) => {});
+    assert.deepStrictEqual(service.serviceName, 'add_two_ints');
+    node.destroy();
+  });  
+});