Skip to content

Commit 6e855e5

Browse files
committed
Address comments
1 parent 31204f4 commit 6e855e5

File tree

5 files changed

+216
-194
lines changed

5 files changed

+216
-194
lines changed

lib/interface_loader.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,9 @@ let interfaceLoader = {
148148
}
149149
}
150150
}
151+
throw new Error(
152+
`The message required does not exist: ${packageName}, ${type}, ${messageName} at ${generator.generatedRoot}`
153+
);
151154
},
152155

153156
loadInterface(packageName, type, messageName) {
@@ -160,7 +163,6 @@ let interfaceLoader = {
160163
}
161164
throw new Error(`The message required does not exist: ${type}`);
162165
}
163-
164166
if (packageName && type && messageName) {
165167
let filePath = path.join(
166168
generator.generatedRoot,
@@ -179,6 +181,7 @@ let interfaceLoader = {
179181
);
180182
}
181183
}
184+
// We cannot parse `packageName`, `type` and `messageName` from the string passed.
182185
throw new Error(
183186
`The message required does not exist: ${packageName}, ${type}, ${messageName} at ${generator.generatedRoot}`
184187
);

rosidl_gen/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,12 @@ async function generateInPath(path) {
5555
}
5656

5757
function generateInPathSyncWorker(targetPath) {
58+
console.log('generateInPathSyncWorker' + targetPath);
5859
try {
5960
// Use child_process.spawnSync for truly synchronous execution
6061
const result = require('child_process').spawnSync(
6162
'node',
62-
[path.join(__dirname, 'generate-worker.js')],
63+
[path.join(__dirname, 'generate_worker.js')],
6364
{
6465
env: { ...process.env, WORKER_TARGET_PATH: targetPath },
6566
encoding: 'utf8',

test/overlay_test_ws/install/geometry_msgs/share/geometry_msgs/msg/Testing.msg

Lines changed: 0 additions & 5 deletions
This file was deleted.

test/test-message-object.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,8 @@ describe('Rclnodejs createMessage() testing', function () {
149149
it('expecting exception when passing ' + testData.toString(), function () {
150150
assert.throws(
151151
() => {
152-
rclnodejs.createMessage(testData);
152+
const t = rclnodejs.createMessage(testData);
153+
console.log(t);
153154
},
154155
function (e) {
155156
return e instanceof Error;

0 commit comments

Comments
 (0)