Skip to content

Commit 898c8dc

Browse files
authored
Remove terser as dependency (#1293)
This PR removes the terser dependency from the project, eliminating JavaScript minification capabilities and replacing them with a simpler whitespace cleanup approach. - Removed terser dependency and import - Replaced minification logic with regex-based empty line removal - Updated development script to remove prettier formatting step Fix: #1293
1 parent 1c0c4af commit 898c8dc

File tree

3 files changed

+193
-206
lines changed

3 files changed

+193
-206
lines changed

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"rebuild:dev": "npm run clean && node-gyp -j 16 rebuild --debug",
2020
"generate-messages": "node scripts/generate_messages.js",
2121
"generate-messages-idl": "node scripts/generate_messages.js --idl",
22-
"generate-messages:dev": "node scripts/generate_messages.js --debug && npx --yes prettier --ignore-path --write generated/**/*.js",
22+
"generate-messages:dev": "node scripts/generate_messages.js --debug",
2323
"generate-tsd-messages": "node scripts/generate_tsd.js",
2424
"clean": "node-gyp clean && npx rimraf ./generated",
2525
"install": "node scripts/install.js",
@@ -83,7 +83,6 @@
8383
"is-close": "^1.3.3",
8484
"json-bigint": "^1.0.0",
8585
"node-addon-api": "^8.3.1",
86-
"terser": "^5.39.0",
8786
"walk": "^2.3.15"
8887
},
8988
"husky": {

rosidl_gen/idl_generator.js

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
'use strict';
1616

1717
const dot = require('dot');
18-
const { minify } = require('terser');
1918
const fse = require('fs-extra');
2019
const path = require('path');
2120
const parser = require('../rosidl_parser/rosidl_parser.js');
@@ -37,18 +36,8 @@ const dots = dot.process({
3736
* @param {string} code
3837
*/
3938
async function writeGeneratedCode(dir, fileName, code) {
40-
let result = null;
41-
if (!isDebug && fileName.endsWith('.js')) {
42-
try {
43-
result = await minify(code);
44-
} catch (error) {
45-
console.error(`Error minifying ${fileName}:`, error);
46-
result = null;
47-
}
48-
}
49-
5039
await fse.mkdirs(dir);
51-
await fse.writeFile(path.join(dir, fileName), result ? result.code : code);
40+
await fse.writeFile(path.join(dir, fileName), code.replace(/^\s*\n/gm, ''));
5241
}
5342

5443
async function generateServiceJSStruct(

0 commit comments

Comments
 (0)