Skip to content

Commit a5edb33

Browse files
authored
Allow installing with Node v12 and update README (#597)
Update package.json to allow installing rclnodejs with Node.js v12, and reflect allowed versions in the README. Fix #None
1 parent 689272a commit a5edb33

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ If you want to select a stable release of ROS 2.0 as your platform, please check
1818
| Dashing Diademata Patch Release [2](https://github.com/ros2/ros2/releases/tag/release-dashing-20190806) | [0.10.1](https://github.com/RobotWebTools/rclnodejs/releases/tag/0.10.1) |
1919
| Dashing Diademata Patch Release [1](https://github.com/ros2/ros2/releases/tag/release-dashing-20190614) | [0.10.0](https://www.npmjs.com/package/rclnodejs/v/0.10.0) |
2020

21-
- Verify that you are using a compatible version of node between 8.12 - 10.99: run `node -v` for your node version info.
21+
- Verify that you are using a compatible version of node between 8.12 - 12.99: run `node -v` for your node version info.
2222

2323
- Install from npmjs: run `npm i rclnodejs@<version>` to install a specific version.
2424

@@ -39,9 +39,9 @@ Alternatively, you can build ROS 2.0 from scratch. Please select the platform yo
3939
### Install `Node.js`
4040

4141
**Notice:**
42-
`rclnodejs` should only be used with node versions between 8.12 - 10.99. The lowest LTS Node.js we used to verify the unit tests is `8.12.0`. And there is a known issue installing rclnodejs with versions of node >= 11.0.
42+
`rclnodejs` should only be used with node versions between 8.12 - 12.99. The lowest LTS Node.js we used to verify the unit tests is `8.12.0`. And there is a known issue installing rclnodejs with versions of node >= 13.0.
4343

44-
The `Node.js` version we selected is the LTS [`Carbon`](https://nodejs.org/download/release/latest-carbon/) (8.x). You can install it:
44+
The `Node.js` version we selected is the LTS [`Erbium`](https://nodejs.org/download/release/latest-erbium/) (12.x). You can install it:
4545

4646
- Download from Node.js offical [website](https://nodejs.org/en/), and install it.
4747
- Use the Node Version Manager ([nvm](https://github.com/creationix/nvm)) to install it.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,6 @@
7575
]
7676
},
7777
"engines": {
78-
"node": ">= 8.12.0 <11.0.0"
78+
"node": ">= 8.12.0 <13.0.0"
7979
}
8080
}

0 commit comments

Comments
 (0)