Reset the error status

Minggang Wang · Minggang Wang · commit b660215b9d42 · 2017-10-20T15:11:56.000+08:00
We must reset the error status to avoid being overwritten by the next one. Calling rcl_reset_error() will meet this when an error happens during taking an response from service. Fix #144
diff --git a/src/rcl_bindings.cpp b/src/rcl_bindings.cpp
@@ -317,11 +317,12 @@ NAN_METHOD(RclTakeResponse) {
   void* taken_response = node::Buffer::Data(info[2]->ToObject());
   rcl_ret_t ret = rcl_take_response(client, header, taken_response);
 
-  if (ret != RCL_RET_CLIENT_TAKE_FAILED) {
+  if (ret == RCL_RET_OK) {
     info.GetReturnValue().Set(Nan::True());
     return;
   }
 
+  rcl_reset_error();
   info.GetReturnValue().Set(Nan::False());
 }
 

Original file line number	Diff line number	Diff line change
`@@ -317,11 +317,12 @@ NAN_METHOD(RclTakeResponse) {`
`317`	`317`	`void* taken_response = node::Buffer::Data(info[2]->ToObject());`
`318`	`318`	`rcl_ret_t ret = rcl_take_response(client, header, taken_response);`
`319`	`319`
`320`		`- if (ret != RCL_RET_CLIENT_TAKE_FAILED) {`
	`320`	`+ if (ret == RCL_RET_OK) {`
`321`	`321`	`info.GetReturnValue().Set(Nan::True());`
`322`	`322`	`return;`
`323`	`323`	`}`
`324`	`324`
	`325`	`+ rcl_reset_error();`
`325`	`326`	`info.GetReturnValue().Set(Nan::False());`
`326`	`327`	`}`
`327`	`328`