Address comments

Author: minggangw

.github/workflows/linux-x64-build-and-test.yml

@@ -74,7 +74,7 @@ jobs:
         npm test
         npm run clean
 
-    - name: Test with IDL ROS messages
+    - name: Test with IDL ROS messages against rolling
       if: ${{ matrix.ros_distribution == 'rolling' }}
       run: |
         source /opt/ros/${{ matrix.ros_distribution }}/setup.bash

rosidl_gen/index.js

@@ -29,17 +29,14 @@ function getInstalledPackagePaths() {
 }
 
 async function generateInPath(path) {
-  let pkgs = null;
   let pkgsInfo = null;
   if (!useIDL) {
-    pkgs = await packages.findPackagesInDirectory(path);
-    pkgsInfo = Array.from(pkgs.values());
+    pkgsInfo = Array.from(
+      (await packages.findPackagesInDirectory(path)).values()
+    );
   } else {
     const idlPkgs = await packages.findPackagesInDirectory(path, useIDL);
-    const exist = await fse.exists(idlPath);
-    if (!exist) {
-      fse.mkdirSync(idlPath);
-    }
+    await fse.ensureDir(idlPath);
     const promises = [];
     idlPkgs.forEach((pkg) => {
       pkg.idls.forEach((idl) => {

rosidl_gen/packages.js

@@ -243,7 +243,7 @@ async function findPackagesInDirectory(dir, useIDL) {
         if (!ignore) {
           if (useIDL) {
             if (path.extname(file.name) === '.idl') {
-              addInterfaceInfo(interfaceInfo, 'idl', pkgMap);
+              addInterfaceInfo(interfaceInfo, 'idls', pkgMap);
             }
           } else {
             if (path.extname(file.name) === '.msg') {

test/test-message-type.js

@@ -105,6 +105,7 @@ describe('Rclnodejs message type testing', function () {
         'String_channel',
         (msg) => {
           publisher.kill('SIGINT');
+          node.destroySubscription(subscription);
           assert.deepStrictEqual(typeof msg.data, 'string');
           assert.deepStrictEqual(msg.data, 'RCL String');
           done();